[PATCH 0/1] MR6094: server: Mark the socket as cacheable when it is an accepted or accepted-into socket.

[Jinoh Kang (＠iamahuman)]

Should fix DJMAX RESPECT V.

Fixes: 89f77a93a6c96896d90c943bc3e82139114cf58c
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56977

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6094

[PATCH 1/1] server: Mark the socket as cacheable when it is an accepted or accepted-into socket.

[Jinoh Kang]

From: Jinoh Kang <jinoh.kang.kr(a)gmail.com>

Fixes: 89f77a93a6c96896d90c943bc3e82139114cf58c
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56977
---
 server/sock.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/server/sock.c b/server/sock.c
index 8a95caded8b..06ffd1b81f8 100644
--- a/server/sock.c
+++ b/server/sock.c
@@ -2045,6 +2045,7 @@ static struct sock *accept_socket( struct sock *sock )
             release_object( acceptsock );
             return NULL;
         }
+        allow_fd_caching( acceptsock->fd );
         unix_len = sizeof(unix_addr);
         if (!getsockname( acceptfd, &unix_addr.addr, &unix_len ))
         {
@@ -2093,6 +2094,7 @@ static int accept_into_socket( struct sock *sock, struct sock *acceptsock )
                                             get_fd_options( acceptsock->fd ) )))
             return FALSE;
     }
+    allow_fd_caching( newfd );
 
     acceptsock->state = SOCK_CONNECTED;
     acceptsock->bound = 1;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6094

[PATCH 1/1] server: Mark the socket as cacheable when it is an accepted or accepted-into socket.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=147141

Your paranoid android.


=== debian11b (64 bit WoW report) ===

user32:
input.c:4305: Test succeeded inside todo block: button_down_hwnd_todo 1: got MSG_TEST_WIN hwnd 0000000000DE0104, msg WM_LBUTTONDOWN, wparam 0x1, lparam 0x320032

[PATCH 0/1] MR6094: server: Mark the socket as cacheable when it is an accepted or accepted-into socket. - approved

[Elizabeth Figura (＠zfigura)]

This merge request was approved by Elizabeth Figura.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6094

[Tatsuyuki Ishi (＠ishitatsuyuki)]

Checked in-game and I no longer see server_get_unix_fd calls on flamegraph on the network thread.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6094#note_76396

[PATCH 0/1] MR6094: server: Mark the socket as cacheable when it is an accepted or accepted-into socket. - approved

[Tatsuyuki Ishi (＠ishitatsuyuki)]

This merge request was approved by Tatsuyuki Ishi.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6094