Re: [PATCH v13 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/tests/system.c:
> +static void test_ShouldSystemUseDarkMode(void)
> +{
> +    DWORD light_theme, light_theme_size = sizeof(light_theme), last_error;
> +    BOOL result;
> +    LSTATUS ls;
> +
> +    pShouldSystemUseDarkMode = (void *)GetProcAddress(GetModuleHandleA("uxtheme.dll"),
> +                                                      MAKEINTRESOURCEA(138));
> +    if (!pShouldSystemUseDarkMode)
> +    {
> +        win_skip("ShouldSystemUseDarkMode() is unavailable.\n");
> +        return;
> +    }
> +
> +    ls = RegGetValueW(HKEY_CURRENT_USER,

I think ShouldSystemUseDarkMode() should use SystemUsesLightTheme registry key instead of AppsUseLightTheme. However, Wine currently doesn't set SystemUsesLightTheme. Let's set SystemUsesLightTheme in winecfg/theme.c on_theme_changed() as well. And change the "WinRT app theme" to "WinRT theme". The winecfg changes should be in a separate commit.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3959#note_47848