[PATCH 0/1] MR2799: mshtml: Remove redundant null check from navigate_uri (Coverity).

[Alex Henrie (＠alexhenrie)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2799

[PATCH 1/1] mshtml: Remove redundant null check from navigate_uri (Coverity).

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

---
 dlls/mshtml/navigate.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/dlls/mshtml/navigate.c b/dlls/mshtml/navigate.c
index eb365c99af9..de16232c3e3 100644
--- a/dlls/mshtml/navigate.c
+++ b/dlls/mshtml/navigate.c
@@ -2559,9 +2559,6 @@ static HRESULT navigate_uri(HTMLOuterWindow *window, IUri *uri, const WCHAR *dis
             }
         }
 
-        if(!window->browser)
-            return S_OK;
-
         if(is_main_content_window(window))
             return super_navigate(window, uri, flags, headers, post_data, post_data_len);
     }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2799

[Gabriel Ivăncescu]

I don't think this is redundant. `FireBeforeNavigate2` could release the document object, which detaches the browser.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2799#note_32648

[Alex Henrie (＠alexhenrie)]

On Thu May 25 15:26:31 2023 +0000, Gabriel Ivăncescu wrote:
> I don't think this is redundant. `FireBeforeNavigate2` could release the
> document object, which detaches the browser.
> OK, thanks for pointing that out. I've marked this issue as a false positive in Coverity.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2799#note_33824

[PATCH 0/1] MR2799: mshtml: Remove redundant null check from navigate_uri (Coverity). - closed

[Alex Henrie (＠alexhenrie)]

This merge request was closed by Alex Henrie.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2799