Re: [PATCH v4 0/1] MR3518: wininet: unify timeout values closer to hInternet
5 Jun
2024
5 Jun
'24
11:33 p.m.
Jacek Caban (@jacek) commented about dlls/wininet/internet.c:
+ if (!lpwhh) + { + SetLastError(ERROR_INTERNET_INCORRECT_HANDLE_TYPE); + return FALSE; + } + if (!lpBuffer || dwBufferLength != sizeof(ULONG)) + { + SetLastError(ERROR_INVALID_PARAMETER); + ret = FALSE; + } + else + { + lpwhh->connect_timeout = *(ULONG *)lpBuffer; + } + break; + } Do we still need it? I think that with implementation in both `set_global_option` and `INET_SetOption`, we could simply remove those cases from `InternetSetOptionW` fallback.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3518#note_72540
563
Age (days ago)
563
Last active (days ago)
0 comments
1 participants
participants (1)
-
Jacek Caban (@jacek)