Re: [PATCH v2 0/1] MR3608: mshtml: check for err before trying to hold plugin host ref
18 Aug
2023
18 Aug
'23
12:40 p.m.
Gabriel Ivăncescu (@insn) commented about dlls/mshtml/npplugin.c:
}
instance->pdata = container->plugin_host; - IOleClientSite_AddRef(&container->plugin_host->IOleClientSite_iface); + if(!err) + IOleClientSite_AddRef(&container->plugin_host->IOleClientSite_iface);
I'd personally check for `container->plugin_host` being non-NULL here instead of checking for err, but it doesn't really matter, depends how Jacek feels about it. Minor nitpick: Please capitalize first word in the commit title (`check`→`Check`) and add a period at the end. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3608#note_42721
849
Age (days ago)
849
Last active (days ago)
0 comments
1 participants
participants (1)
-
Gabriel Ivăncescu