[PATCH 0/1] MR5557: win32u: Set the virtual desktop display frequency to 60Hz.

[Zhiyi Zhang (＠zhiyi)]

Fix a regression from ee0aad5c, which changes the virtual desktop display frequency to that of
the host display while adding modes of 60Hz. So when the host display is not 60Hz, we might get
ChangeDisplaySettings() failures when virtual desktop is on because the target mode is not found
because of the frequency difference.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5557

[PATCH 1/1] win32u: Set the virtual desktop display frequency to 60Hz.

[Zhiyi Zhang]

From: Zhiyi Zhang <zzhang(a)codeweavers.com>

Fix a regression from ee0aad5c, which changes the virtual desktop display frequency to that of
the host display while adding modes of 60Hz. So when the host display is not 60Hz, we might get
ChangeDisplaySettings() failures when virtual desktop is on because the target mode is not found
because of the frequency difference.
---
 dlls/win32u/sysparams.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/win32u/sysparams.c b/dlls/win32u/sysparams.c
index d2ac6d5bfb2..cc6bd8e7628 100644
--- a/dlls/win32u/sysparams.c
+++ b/dlls/win32u/sysparams.c
@@ -1900,6 +1900,7 @@ static BOOL desktop_update_display_devices( BOOL force, struct device_manager_ct
     if (!read_source_mode( ctx->source_key, ENUM_CURRENT_SETTINGS, ¤t ))
     {
         current = desktop_ctx.primary;
+        current.dmDisplayFrequency = 60;
         current.dmPelsWidth = screen_width;
         current.dmPelsHeight = screen_height;
     }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/5557

[PATCH 1/1] win32u: Set the virtual desktop display frequency to 60Hz.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=145287

Your paranoid android.


=== debian11b (64 bit WoW report) ===

user32:
input.c:3875: Test succeeded inside todo block: button_down_hwnd_todo 1: got MSG_TEST_WIN hwnd 00000000021E00CA, msg WM_LBUTTONDOWN, wparam 0x1, lparam 0x320032

[Rémi Bernon]

Approving this too although I think it could be merged with !5422 which now includes it.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5557#note_69230

[PATCH 0/1] MR5557: win32u: Set the virtual desktop display frequency to 60Hz. - approved

[Rémi Bernon]

This merge request was approved by Rémi Bernon.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5557