[PATCH 0/1] MR3608: mshtml: check for err before trying to hold plugin host ref

[James Beddek (＠telans)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55457
Signed-off-by: James Beddek <telans(a)posteo.de>

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3608

[PATCH 1/1] mshtml: check for err before trying to hold plugin host ref

[James Beddek]

From: James Beddek <telans(a)posteo.de>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55457
Signed-off-by: James Beddek <telans(a)posteo.de>
---
 dlls/mshtml/npplugin.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/mshtml/npplugin.c b/dlls/mshtml/npplugin.c
index 6dfb65c0a6e..b056024aca5 100644
--- a/dlls/mshtml/npplugin.c
+++ b/dlls/mshtml/npplugin.c
@@ -301,7 +301,8 @@ static NPError CDECL NPP_New(NPMIMEType pluginType, NPP instance, UINT16 mode, I
     }
 
     instance->pdata = container->plugin_host;
-    IOleClientSite_AddRef(&container->plugin_host->IOleClientSite_iface);
+    if(!err)
+        IOleClientSite_AddRef(&container->plugin_host->IOleClientSite_iface);
 
     node_release(&container->element.node);
     return err;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3608