[PATCH 0/1] MR1583: atl: Fix memory leak on error path in do_process_root_key (scan-build).

[Alex Henrie (＠alexhenrie)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1583

[PATCH 1/1] atl: Fix memory leak on error path in do_process_root_key (scan-build).

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

---
 dlls/atl/registrar.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/atl/registrar.c b/dlls/atl/registrar.c
index 5e03b42132c..9009cd1c7cf 100644
--- a/dlls/atl/registrar.c
+++ b/dlls/atl/registrar.c
@@ -383,7 +383,7 @@ static HRESULT do_process_root_key(LPCOLESTR data, BOOL do_register)
     strbuf_init(&buf);
     hres = get_word(&iter, &buf);
     if(FAILED(hres))
-        return hres;
+        goto done;
 
     while(*iter) {
         if(!buf.len) {
@@ -417,6 +417,8 @@ static HRESULT do_process_root_key(LPCOLESTR data, BOOL do_register)
         if(FAILED(hres))
             break;
     }
+
+done:
     free(buf.str);
     return hres;
 }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1583

[PATCH 1/1] atl: Fix memory leak on error path in do_process_root_key (scan-build).

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=126901

Your paranoid android.


=== debian11 (32 bit report) ===

wldap32:
parse.c:245: Test failed: ldap_get_next_page_s failed 0x51
parse.c:246: Test failed: expected res != NULL
parse.c:247: Test failed: got 3735928559
Unhandled exception: page fault on read access to 0x0000001c in 32-bit code (0x6f8d7bce).

wmvcore:
wmvcore.c:3007: Test failed: Wait timed out.

ws2_32:
sock.c:6775: Test succeeded inside todo block: event series matches
sock.c:6785: Test failed: got unexpected event 0x20
sock.c:6785: Test failed: event series matches

Report validation errors:
advapi32:security has no test summary line (early exit of the main process?)
advapi32:security has unaccounted for todo messages