[PATCH 0/1] MR6676: conhost: Start input thread in IOCTL_CONDRV_GET_INPUT_INFO ioctl.

[Piotr Caban (＠piotr)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6676

[PATCH 1/1] conhost: Start input thread in IOCTL_CONDRV_GET_INPUT_INFO ioctl.

[Piotr Caban]

From: Piotr Caban <piotr(a)codeweavers.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56697
---
 programs/conhost/conhost.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/programs/conhost/conhost.c b/programs/conhost/conhost.c
index 7610cb69c72..321b4e6c967 100644
--- a/programs/conhost/conhost.c
+++ b/programs/conhost/conhost.c
@@ -2691,6 +2691,7 @@ static NTSTATUS console_input_ioctl( struct console *console, unsigned int code,
             struct condrv_input_info *info;
             TRACE( "get info\n" );
             if (in_size || *out_size != sizeof(*info)) return STATUS_INVALID_PARAMETER;
+            ensure_tty_input_thread( console );
             if (!(info = alloc_ioctl_buffer( sizeof(*info )))) return STATUS_NO_MEMORY;
             info->input_cp    = console->input_cp;
             info->output_cp   = console->output_cp;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6676

[PATCH 1/1] conhost: Start input thread in IOCTL_CONDRV_GET_INPUT_INFO ioctl.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=149021

Your paranoid android.


=== debian11b (64 bit WoW report) ===

kernel32:
comm.c:1574: Test failed: AbortWaitCts hComPortEvent failed
comm.c:1586: Test failed: Unexpected time 1002, expected around 500

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about programs/conhost/conhost.c:
> struct condrv_input_info *info;
>              TRACE( "get info\n" );
>              if (in_size || *out_size != sizeof(*info)) return STATUS_INVALID_PARAMETER;
> +            ensure_tty_input_thread( console );

I guess it's about `input_count` needed for `GetNumberOfConsoleInputEvents`. `GetConsole*CP` functions are much more common and don't need input thread, maybe we should split the ioctl.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6676#note_85024

[Piotr Caban (＠piotr)]

On Tue Oct 15 17:21:18 2024 +0000, Jacek Caban wrote:
> I guess it's about `input_count` needed for
> `GetNumberOfConsoleInputEvents`. `GetConsole*CP` functions are much more
> common and don't need input thread, maybe we should split the ioctl.
> Yes, it's for `GetNumberOfConsoleInputEvents` used by `_kbhit`. I'll introduce new ioctl for input_count.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6676#note_85025