Re: [PATCH v13 0/1] MR6453: emfdc: avoid memory leaks in get_bitmap_info

[AlexeyLushnikov (＠AlexeyLushnikov)]

On Wed Sep 11 16:44:51 2024 +0000, Jacek Caban wrote:
> You could just return 0 here, which would allow you to simplify the code
> some more. Then you don't need the assignment above. And without that
> assignment, we could remove `blit_dc != *hdc` check from error handling path.
> I think we could remove `blit_bitmap != *bitmap` from error handle too. We don't assign `*bitmap` to `blit_bitmap` before the last `goto err`.

And we could remove `if(blit_dc)` check too. We return FALSE if `NtGdiCreateCompatibleDC` fails and `blit_dc` doesn't change before the last `goto err`.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6453#note_81990