[PATCH 0/1] MR3745: user32/tests: Check all letters in test_hotkey.
From: Esme Povirk <esme(a)codeweavers.com> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55317 --- dlls/user32/tests/msg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index c1f950e5cb9..36614ffde30 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -18629,7 +18629,7 @@ static void test_hotkey(void) "unexpected error %ld\n", GetLastError()); /* Search for a Windows Key + letter combination that hasn't been registered */ - for (hotkey_letter = 0x41; hotkey_letter <= 0x51; hotkey_letter ++) + for (hotkey_letter = 0x41; hotkey_letter <= 0x5A; hotkey_letter ++) { SetLastError(0xdeadbeef); ret = RegisterHotKey(test_window, 5, MOD_WIN, hotkey_letter); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/3745
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=137067 Your paranoid android. === w7u_2qxl (32 bit report) === user32: msg.c:8938: Test failed: SetWindowPos:FrameChanged_clip: 2: the msg 0x0085 was expected in parent msg.c:8938: Test failed: SetWindowPos:FrameChanged_clip: 4: the msg 0x0014 was expected in parent msg.c:8938: Test failed: SetWindowPos:FrameChanged_clip: 5: the msg 0x0085 was expected, but got msg 0x0047 instead msg.c:8938: Test failed: SetWindowPos:FrameChanged_clip: 6: the msg 0x0014 was expected, but got msg 0x0047 instead msg.c:8948: Test failed: SetWindowPos:FrameChangedDeferErase: 4: the msg 0x000f was expected in parent msg.c:8948: Test failed: SetWindowPos:FrameChangedDeferErase: 5: the msg 0x0085 was expected in parent msg.c:8948: Test failed: SetWindowPos:FrameChangedDeferErase: 6: the msg sequence is not complete: expected msg 000f - actual msg 0000 msg.c:8976: Test failed: SetWindowPos:FrameChangedDeferErase: 4: the msg 0x000f was expected in parent msg.c:8976: Test failed: SetWindowPos:FrameChangedDeferErase: 5: the msg 0x0085 was expected in parent msg.c:8976: Test failed: SetWindowPos:FrameChangedDeferErase: 6: the msg sequence is not complete: expected msg 000f - actual msg 0000 === debian11 (32 bit he:IL report) === user32: msg.c:19596: Test succeeded inside todo block: thread_2: WaitForSingleObject failed, ret:0 msg.c:19620: Test succeeded inside todo block: thread_2: wrong status 00000000
Not that it's necessarily worth rerolling this, but maybe we should be writing 'A' and 'Z' instead? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3745#note_44470
participants (4)
-
Esme Povirk -
Esme Povirk (＠madewokherd)
-
Marvin -
Zebediah Figura (＠zfigura)