Re: [PATCH v2 0/1] MR8137: kernel32: Implement ReadConsoleInputEx
25 May
2025
25 May
'25
7:32 a.m.
a couple of comments: * please read and conform to [Wine Coding style](https://gitlab.winehq.org/wine/wine/-/wikis/Wine-Developer's-Guide/Coding-Practice#some-notes-about-style) * AFAICT ReadConsoleInputEx\[AW\] isn't defined in Windows SDK so header files shouldn't be changed * tests must reflect what Windows does, not what your implementation does (hence the generated failures in CI pipeline) * this should be implemented using proper (new or modified) IOCTL:s; there's no way this API can be implemented on top of kernel32's one without being racy (as your proposal is). That's the reason why MS introduced this new API. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8137#note_104458
284
Age (days ago)
284
Last active (days ago)
0 comments
1 participants
participants (1)
-
eric pouech (@epo)