[PATCH 0/1] MR2925: iphlpapi: Add GetCurrentThreadCompartmentId stub.
From: Alex Henrie <alexhenrie24(a)gmail.com> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54599 --- dlls/iphlpapi/iphlpapi.spec | 2 +- dlls/iphlpapi/iphlpapi_main.c | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/dlls/iphlpapi/iphlpapi.spec b/dlls/iphlpapi/iphlpapi.spec index 90bf290c9bd..76701d686e0 100644 --- a/dlls/iphlpapi/iphlpapi.spec +++ b/dlls/iphlpapi/iphlpapi.spec @@ -80,7 +80,7 @@ @ stdcall GetBestRoute( long long ptr ) @ stdcall GetBestRoute2( ptr long ptr ptr long ptr ptr ) @ stub GetBestRouteFromStack -#@ stub GetCurrentThreadCompartmentId +@ stdcall GetCurrentThreadCompartmentId() @ stdcall GetExtendedTcpTable( ptr ptr long long long long ) @ stdcall GetExtendedUdpTable( ptr ptr long long long long ) @ stdcall GetFriendlyIfIndex( long ) diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c index d22209ff719..ae9ee0e7325 100644 --- a/dlls/iphlpapi/iphlpapi_main.c +++ b/dlls/iphlpapi/iphlpapi_main.c @@ -4750,3 +4750,12 @@ DWORD WINAPI Icmp6SendEcho2( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc_ro SetLastError( ERROR_CALL_NOT_IMPLEMENTED ); return 0; } + +/*********************************************************************** + * GetCurrentThreadCompartmentId (IPHLPAPI.@) + */ +NET_IF_COMPARTMENT_ID WINAPI GetCurrentThreadCompartmentId( void ) +{ + FIXME( "stub\n" ); + return NET_IF_COMPARTMENT_ID_UNSPECIFIED; +} -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/2925
Huw Davies (@huw) commented about dlls/iphlpapi/iphlpapi_main.c:
SetLastError( ERROR_CALL_NOT_IMPLEMENTED ); return 0; } + +/*********************************************************************** + * GetCurrentThreadCompartmentId (IPHLPAPI.@) + */ +NET_IF_COMPARTMENT_ID WINAPI GetCurrentThreadCompartmentId( void ) +{ + FIXME( "stub\n" ); + return NET_IF_COMPARTMENT_ID_UNSPECIFIED;
I suspect returning `NET_IF_COMPARTMENT_ID_PRIMARY` would be less surprising, although a test wouldn't hurt. ```suggestion:-0+0 return NET_IF_COMPARTMENT_ID_PRIMARY; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2925#note_34117
participants (3)
-
Alex Henrie -
Alex Henrie (@alexhenrie) -
Huw Davies (@huw)