[PATCH v2 0/1] MR9961: d2d1: Partially implement d2d_device_context_Flush().

[Zhiyi Zhang (＠zhiyi)]

React Native applications rely on d2d_device_context_Flush() returning S_OK.

--
  v2: d2d1: Return S_OK for d2d_device_context_Flush().
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9961

[PATCH v2 1/1] d2d1: Return S_OK for d2d_device_context_Flush().

[Zhiyi Zhang]

From: Zhiyi Zhang <[e-mail]>

React Native applications depend on this.

Wine-Bug: http://bugs.winehq.org/show_bug.cgi?id=50814
---
 dlls/d2d1/device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/d2d1/device.c b/dlls/d2d1/device.c
index ac1220bc9b3..eeb3029552b 100644
--- a/dlls/d2d1/device.c
+++ b/dlls/d2d1/device.c
@@ -1865,7 +1865,7 @@ static HRESULT STDMETHODCALLTYPE d2d_device_context_Flush(ID2D1DeviceContext6 *i
     if (context->ops && context->ops->device_context_present)
         context->ops->device_context_present(context->outer_unknown);
 
-    return E_NOTIMPL;
+    return S_OK;
 }
 
 static void STDMETHODCALLTYPE d2d_device_context_SaveDrawingState(ID2D1DeviceContext6 *iface,
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/9961

[Nikolay Sivov (＠nsivov)]

On Sun Feb  1 02:49:48 2026 +0000, Zhiyi Zhang wrote:
> We could. This is a bit more complete than simply returning S_OK, no? I
> was trying to mimic the behavior shown by the tests.
> I think making it succeed is fine for now, when implemented it should execute current batch and present with current target. And that potentially could depend on a target type.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9961#note_129062

[Zhiyi Zhang (＠zhiyi)]

On Sun Feb  8 15:52:37 2026 +0000, Nikolay Sivov wrote:
> I think making it succeed is fine for now, when implemented it should
> execute current batch and present with current target. And that
> potentially could depend on a target type.
> I've made the changes to simply return S_OK. thanks.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9961#note_129063

[PATCH v2 0/1] MR9961: d2d1: Partially implement d2d_device_context_Flush(). - approved

[Nikolay Sivov (＠nsivov)]

This merge request was approved by Nikolay Sivov.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9961