Re: [PATCH v3 0/1] MR68: vkd3d-shader/hlsl: Support frac() intrinsic.
25 Jan
2023
25 Jan
'23
7:52 a.m.
I do think that as a matter of principle having test coverage for the different intrinsics we implement is simply a good idea. These tests don't necessarily need to be complicated; see e.g. "sqrt.shader_test" for a straightforward example.
For the record, at some point I duplicated some tests so that both the constant folding path and the real codegen path would be tested. See for example `arithmetic-float.shader_test` vs `arithmetic-float-uniform.shader_test`. It wouldn't probably be a bad idea to make that more systematic, but I agree that's not a requirement for this MR. Just saying. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/68#note_21781
1056
Age (days ago)
1056
Last active (days ago)
0 comments
1 participants
participants (1)
-
Giovanni Mascellani (@giomasce)