[PATCH v2 0/1] MR5960: ntdll: Remove superflous null check (coverity)

[Fabian Maurer (＠DarkShadow44)]

It's dereferenced later in create_window_handle anyways

--
  v2: win32u: Remove superflous null check (coverity).
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5960

[PATCH v2 1/1] win32u: Remove superflous null check (coverity).

[Fabian Maurer]

From: Fabian Maurer <dark.shadow4(a)web.de>

It's dereferenced later in create_window_handle anyways
---
 dlls/win32u/window.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/win32u/window.c b/dlls/win32u/window.c
index 841ab220074..8c510ec9729 100644
--- a/dlls/win32u/window.c
+++ b/dlls/win32u/window.c
@@ -5174,7 +5174,7 @@ HWND WINAPI NtUserCreateWindowEx( DWORD ex_style, UNICODE_STRING *class_name,
     cs.style      = style;
     cs.dwExStyle  = ex_style;
     cs.lpszName   = window_name ? window_name->Buffer : NULL;
-    cs.lpszClass  = class_name ? class_name->Buffer : NULL;
+    cs.lpszClass  = class_name->Buffer;
     cs.x  = x;
     cs.y  = y;
     cs.cx = cx;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/5960

[PATCH v2 1/1] win32u: Remove superflous null check (coverity).

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=147516

Your paranoid android.


=== debian11b (64 bit WoW report) ===

user32:
input.c:4305: Test succeeded inside todo block: button_down_hwnd_todo 1: got MSG_TEST_WIN hwnd 0000000000E200DA, msg WM_LBUTTONDOWN, wparam 0x1, lparam 0x320032

[Fabian Maurer (＠DarkShadow44)]

On Fri Aug  2 21:43:16 2024 +0000, Jacek Caban wrote:
> It seems fine to me, but the commit message should mention win32u, not ntdll.
> Oh. Thanks, updated!

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5960#note_77720

[PATCH v2 0/1] MR5960: win32u: Remove superflous null check (coverity) - approved

[Jacek Caban (＠jacek)]

This merge request was approved by Jacek Caban.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5960