Re: [PATCH v7 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec

[Alfred Agrell (＠Alcaro)]

On Sun Oct  1 23:30:07 2023 +0000, YuriK7 wrote:
> Thanks ! 
> The game I mentioned (touhou sky fight) is a weird case. It already
> hangs (actually it just errors out and closes) without your patch on
> vanilla wine whit the gstreamer shipped with wine-ge 8-16 where they
> updated it to 1.22. With the old gstreamer it used to be a skippable
> black screen, however adding gstkrkr makes it crash. This merge doesn't
> seem to change anything on that so be reassured, I guess I should open
> either a wine issue or a gstreamer issue...
> But Azumanga Fighter, Higurashi Daybreak Kai and HaruToma 2 works
> perfectly well with the new gstreamer + gstkrkr (the new version show a
> color bars screen when the codec is missing, instead of playing the sound).
> Yes, that is consistent with my experience. I tried Azumanga (everything looks good to me with this patch) and Touhou (crashes on Wine 8.17, Wine 8.17 with this patch, and Debian's Wine 8.0; different output before the crash, but they all segfault in SampleGrabber_ISampleGrabber_GetCurrentBuffer). Sounds like a different bug to me.

The color bars are not a Wine bug; they're protonmediaconverter. It does that if it can't find a converted version of the media, which it can't if you're running it outside Steam. gstkrkr fills that exact hole. (gstkrkr also does a little trick to ensure ffmpeg's WMA audio decoder is selected instead of mediaconverter.)

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47318