Re: [PATCH v4 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour

[eric pouech (＠epo)]

eric pouech (@epo) commented about dlls/ntdll/tests/directory.c:
> +    InitializeObjectAttributes(&attr, &ntdirname, OBJ_CASE_INSENSITIVE, 0, NULL);
> +
> +	/* Open a handle for our test directory */
> +	status = pNtOpenFile(&dirh, SYNCHRONIZE | FILE_LIST_DIRECTORY, &attr, &io, FILE_SHARE_READ,
> +                         FILE_SYNCHRONOUS_IO_NONALERT | FILE_OPEN_FOR_BACKUP_INTENT | FILE_DIRECTORY_FILE);
> +    ok( status == STATUS_SUCCESS, "failed to open dir '%s', ret 0x%lx, error %ld\n", testdir, status, GetLastError() );
> +    if (status != STATUS_SUCCESS)
> +    {
> +       skip("can't test if we can't open the directory\n");
> +       goto done;
> +    }
> +
> +    /* Verify that updated windows 8 and higher behaviour is supported */
> +    if (!winetest_platform_is_wine && !test_NtQueryDirectoryFile_mask(dirh, TRUE, atestfile, TRUE, TRUE))
> +        run_updated_tests = FALSE;
> +    if (!winetest_platform_is_wine && !test_NtQueryDirectoryFile_mask(dirh, TRUE, notatestfile, FALSE, TRUE))
> question: do you need both calls to test_NtQueryDirectoryFile_mask to invalidate a platform?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6904#note_89399