[PATCH 0/1] MR4011: wpcap: get_broadcast return NULL on error

[Alistair Leslie-Hughes (＠alesliehughes)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4011

[PATCH 1/1] wpcap: get_broadcast return NULL on error

[Alistair Leslie-Hughes]

From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>

---
 dlls/wpcap/wpcap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/wpcap/wpcap.c b/dlls/wpcap/wpcap.c
index 6ad4fc5f04f..de4bac33871 100644
--- a/dlls/wpcap/wpcap.c
+++ b/dlls/wpcap/wpcap.c
@@ -519,7 +519,7 @@ static struct sockaddr *get_broadcast( const IP_ADAPTER_UNICAST_ADDRESS *addr )
         struct sockaddr_in *broadcast_addr_in, *addr_in = (struct sockaddr_in *)addr->Address.lpSockaddr;
         ULONG netmask;
 
-        if (!(broadcast_addr_in = calloc( 1, sizeof(*broadcast_addr_in) ))) return FALSE;
+        if (!(broadcast_addr_in = calloc( 1, sizeof(*broadcast_addr_in) ))) return NULL;
         broadcast_addr_in->sin_family = AF_INET;
         ConvertLengthToIpv4Mask( addr->OnLinkPrefixLength, &netmask );
         broadcast_addr_in->sin_addr.S_un.S_addr = addr_in->sin_addr.S_un.S_addr | ~netmask;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4011

[PATCH 1/1] wpcap: get_broadcast return NULL on error

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=138280

Your paranoid android.


=== debian11b (64 bit WoW report) ===

mshtml:
script: Timeout
xmlhttprequest: Timeout

msxml3:
httpreq: Timeout

qmgr:
job.c:783: Test failed: unexpected state: 4
job.c:783: Test failed: unexpected state: 4
job.c:783: Test failed: unexpected state: 4
job.c:783: Test failed: unexpected state: 4
job.c:783: Test failed: unexpected state: 4
job.c:783: Test failed: unexpected state: 4
job.c:783: Test failed: unexpected state: 4
job.c:783: Test failed: unexpected state: 4
job.c:783: Test failed: unexpected state: 4
job.c:783: Test failed: unexpected state: 4
job.c:508: Test failed: Failed to get error: 0x8020000f
job.c:802: Test failed: BITS job timed out
job.c:834: Test failed: got 0x00200017

urlmon:
protocol.c:1199: Test failed: hrResult = 800c0008, expected: 00000000
protocol.c:1204: Test failed: dwError == ERROR_SUCCESS
url.c:1845: Test failed: binding failed: 800c0008, expected 00000000
url.c:3186: Test failed: IMoniker_BindToStorage failed: 800c0008
url.c:3187: Test failed: unk == NULL
url.c:1845: Test failed: binding failed: 800c0008, expected 00000000
url.c:3186: Test failed: IMoniker_BindToStorage failed: 800c0008
url.c:3187: Test failed: unk == NULL
url.c:1845: Test failed: binding failed: 800c0008, expected 00000000
url.c:3456: Test failed: IMoniker_BindToStorage failed: 800c0008
url.c:3457: Test failed: unk == NULL
url.c:3509: Test failed: expected Obj_OnProgress_SENDINGREQUEST
url.c:3513: Test failed: expected OnResponse
url.c:3515: Test failed: expected Obj_OnProgress_MIMETYPEAVAILABLE
url.c:3516: Test failed: expected Obj_OnProgress_BEGINDOWNLOADDATA
url.c:3524: Test failed: expected Obj_OnProgress_BEGINSYNCOPERATION
url.c:3530: Test failed: expected Obj_OnProgress_ENDSYNCOPERATION

[PATCH 0/1] MR4011: wpcap: get_broadcast return NULL on error - approved

[Hans Leidekker (＠hans)]

This merge request was approved by Hans Leidekker.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4011