[PATCH v2 0/2] MR1832: mfmediaengine: Pause the session in media_engine_Pause.

[Shaun Ren (＠shaunren)]

--
  v2: mfmediaengine: Pause the session in media_engine_Pause.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1832

[PATCH v2 1/2] mfmediaengine: Change media_engine_Shutdown FIXME to TRACE.

[Shaun Ren]

From: Shaun Ren <sren(a)codeweavers.com>

---
 dlls/mfmediaengine/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/mfmediaengine/main.c b/dlls/mfmediaengine/main.c
index f2fae1cac3e..27dafd616a2 100644
--- a/dlls/mfmediaengine/main.c
+++ b/dlls/mfmediaengine/main.c
@@ -2123,7 +2123,7 @@ static HRESULT WINAPI media_engine_Shutdown(IMFMediaEngineEx *iface)
     struct media_engine *engine = impl_from_IMFMediaEngineEx(iface);
     HRESULT hr = S_OK;
 
-    FIXME("(%p): stub.\n", iface);
+    TRACE("%p.\n", iface);
 
     EnterCriticalSection(&engine->cs);
     if (engine->flags & FLAGS_ENGINE_SHUT_DOWN)
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/1832

[PATCH v2 2/2] mfmediaengine: Pause the session in media_engine_Pause.

[Shaun Ren]

From: Shaun Ren <sren(a)codeweavers.com>

---
 dlls/mfmediaengine/main.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/dlls/mfmediaengine/main.c b/dlls/mfmediaengine/main.c
index 27dafd616a2..63e9a8f07d5 100644
--- a/dlls/mfmediaengine/main.c
+++ b/dlls/mfmediaengine/main.c
@@ -1952,11 +1952,14 @@ static HRESULT WINAPI media_engine_Pause(IMFMediaEngineEx *iface)
     {
         if (!(engine->flags & FLAGS_ENGINE_PAUSED))
         {
-            media_engine_set_flag(engine, FLAGS_ENGINE_WAITING | FLAGS_ENGINE_IS_ENDED, FALSE);
-            media_engine_set_flag(engine, FLAGS_ENGINE_PAUSED, TRUE);
+            if (SUCCEEDED(hr = IMFMediaSession_Pause(engine->session)))
+            {
+                media_engine_set_flag(engine, FLAGS_ENGINE_WAITING | FLAGS_ENGINE_IS_ENDED, FALSE);
+                media_engine_set_flag(engine, FLAGS_ENGINE_PAUSED, TRUE);
 
-            IMFMediaEngineNotify_EventNotify(engine->callback, MF_MEDIA_ENGINE_EVENT_TIMEUPDATE, 0, 0);
-            IMFMediaEngineNotify_EventNotify(engine->callback, MF_MEDIA_ENGINE_EVENT_PAUSE, 0, 0);
+                IMFMediaEngineNotify_EventNotify(engine->callback, MF_MEDIA_ENGINE_EVENT_TIMEUPDATE, 0, 0);
+                IMFMediaEngineNotify_EventNotify(engine->callback, MF_MEDIA_ENGINE_EVENT_PAUSE, 0, 0);
+            }
         }
 
         IMFMediaEngineNotify_EventNotify(engine->callback, MF_MEDIA_ENGINE_EVENT_PURGEQUEUEDEVENTS, 0, 0);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1832

[PATCH v2 0/2] MR1832: mfmediaengine: Pause the session in media_engine_Pause. - approved

[Nikolay Sivov (＠nsivov)]

This merge request was approved by Nikolay Sivov.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1832