[PATCH 0/1] MR4146: setupapi: Prevent certain applications from entering an endless loop during the installation process.

[kingjinni (＠kingjinni)]

setupapi: Prevent certain applications from entering an endless loop during the installation process.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4146

[PATCH 1/1] setupapi: Prevent certain applications from entering an endless loop during the installation process.

[kingjinni]

From: kingjinni <kingtin0419(a)qq.com>

---
 dlls/setupapi/devinst.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dlls/setupapi/devinst.c b/dlls/setupapi/devinst.c
index 2a8820ba07f..2a1689a5016 100644
--- a/dlls/setupapi/devinst.c
+++ b/dlls/setupapi/devinst.c
@@ -3169,7 +3169,10 @@ BOOL WINAPI SetupDiGetDeviceRegistryPropertyW(HDEVINFO devinfo,
             SetLastError(l);
         if (RequiredSize)
             *RequiredSize = size;
+    } else {
+        SetLastError(ERROR_INVALID_DATA);
     }
+
     return ret;
 }
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4146

[Zebediah Figura (＠zfigura)]

What property are these applications querying? Should we map it?

Making this change anyway is probably a good idea, however:

* we should fix the A function as well;

* we should probably have a FIXME for this case;

* please fix the coding style (braces go on a separate line);

* a test would be nice;

* Wine requires that all contributors use their real name.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4146#note_49451

[Zebediah Figura (＠zfigura)]

Also, the subject line of the patch should ideally describe what the patch does, not what bug it fixes. The fixed bug should be mentioned (ideally with the name of the actual application affected), but not as the first line of the commit message.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4146#note_49452