[PATCH 0/1] MR2007: services: Use a separate allocation for NotifyParamsArray[0].params.

[Rémi Bernon]

The pointer might be freed by RPC NdrPointerFree, which will try to use
a dedicated free call for the array elements, and fail.

Found by running advapi32:service test with warn+heap.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2007

[PATCH 1/1] services: Use a separate allocation for NotifyParamsArray[0].params.

[Rémi Bernon]

From: Rémi Bernon <rbernon(a)codeweavers.com>

The pointer might be freed by RPC NdrPointerFree, which will try to use
a dedicated free call for the array elements, and fail.
---
 programs/services/rpc.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/programs/services/rpc.c b/programs/services/rpc.c
index de918d33b1f..e56d25ea1af 100644
--- a/programs/services/rpc.c
+++ b/programs/services/rpc.c
@@ -102,6 +102,8 @@ static void sc_notify_release(struct sc_notify_handle *notify)
     if (r == 0)
     {
         CloseHandle(notify->event);
+        if (notify->params_list)
+            free(notify->params_list->NotifyParamsArray[0].params);
         free(notify->params_list);
         free(notify);
     }
@@ -841,11 +843,14 @@ static void fill_notify(struct sc_notify_handle *notify, struct service_entry *s
     SC_RPC_NOTIFY_PARAMS_LIST *list;
     SERVICE_NOTIFY_STATUS_CHANGE_PARAMS_2 *cparams;
 
-    list = calloc(1, sizeof(SC_RPC_NOTIFY_PARAMS_LIST) + sizeof(SERVICE_NOTIFY_STATUS_CHANGE_PARAMS_2));
+    list = calloc(1, sizeof(SC_RPC_NOTIFY_PARAMS_LIST));
     if (!list)
         return;
-
-    cparams = (SERVICE_NOTIFY_STATUS_CHANGE_PARAMS_2 *)(list + 1);
+    if (!(cparams = calloc(1, sizeof(SERVICE_NOTIFY_STATUS_CHANGE_PARAMS_2))))
+    {
+        free(list);
+        return;
+    }
 
     cparams->dwNotifyMask = notify->notify_mask;
     fill_status_process(&cparams->ServiceStatus, service);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2007