Re: [PATCH v5 0/8] MR3249: windows.networking.hostname: Implement IHostNameFactory::CreateHostName().
7 Jul
2023
7 Jul
'23
8:46 p.m.
Nikolay Sivov (@nsivov) commented about dlls/windows.networking.hostname/hostname.c:
+ struct hostname *impl; + + TRACE( "iface %p, name %s, value %p\n", iface, debugstr_hstring(name), value ); + + if (!value) return E_POINTER; + if (!name) return E_INVALIDARG; + if (!(impl = calloc( 1, sizeof(*impl) ))) return E_OUTOFMEMORY; + + impl->IHostName_iface.lpVtbl = &hostname_vtbl; + impl->ref = 1; + impl->rawname = name; + + *value = &impl->IHostName_iface; + TRACE( "created IHostName %p.\n", *value ); + return S_OK; } Shouldn't this duplicate the string?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3249#note_38364
894
Age (days ago)
894
Last active (days ago)
0 comments
1 participants
participants (1)
-
Nikolay Sivov (@nsivov)