Re: [PATCH v5 0/8] MR3249: windows.networking.hostname: Implement IHostNameFactory::CreateHostName().

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/windows.networking.hostname/hostname.c:
> +    struct hostname *impl;
> +
> +    TRACE( "iface %p, name %s, value %p\n", iface, debugstr_hstring(name), value );
> +
> +    if (!value) return E_POINTER;
> +    if (!name) return E_INVALIDARG;
> +    if (!(impl = calloc( 1, sizeof(*impl) ))) return E_OUTOFMEMORY;
> +
> +    impl->IHostName_iface.lpVtbl = &hostname_vtbl;
> +    impl->ref = 1;
> +    impl->rawname = name;
> +
> +    *value = &impl->IHostName_iface;
> +    TRACE( "created IHostName %p.\n", *value );
> +    return S_OK;
>  }
> Shouldn't this duplicate the string?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3249#note_38364