[PATCH 0/1] MR3730: comctl32: Use iswalnum() to filter alpha numeric characters from unicode messages.

[Dmitry Timoshkov (＠dmitry)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3730

[PATCH 1/1] comctl32: Use iswalnum() to filter alpha numeric characters from unicode messages.

[Dmitry Timoshkov]

From: Dmitry Timoshkov <dmitry(a)baikal.ru>

Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru>
---
 dlls/comctl32/treeview.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/comctl32/treeview.c b/dlls/comctl32/treeview.c
index c4e8d926941..c531ad75370 100644
--- a/dlls/comctl32/treeview.c
+++ b/dlls/comctl32/treeview.c
@@ -4664,7 +4664,7 @@ static INT TREEVIEW_ProcessLetterKeys(TREEVIEW_INFO *infoPtr, WPARAM charCode, L
     if (!charCode || !keyData) return 0;
 
     /* only allow the valid WM_CHARs through */
-    if (!isalnum(charCode) &&
+    if (!iswalnum(charCode) &&
         charCode != '.' && charCode != '`' && charCode != '!' &&
         charCode != '@' && charCode != '#' && charCode != '$' &&
         charCode != '%' && charCode != '^' && charCode != '&' &&
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3730

[PATCH 1/1] comctl32: Use iswalnum() to filter alpha numeric characters from unicode messages.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=137017

Your paranoid android.


=== debian11b (64 bit WoW report) ===

d3d10core:
d3d10core.c:16278: Test failed: Format 0x2d: slope 1.000000: scale 2.000000, clamp 0.000010: Got value 0xffffff (1.00000000e+000), expected 0xa47f (2.51001143e-003).

[PATCH 0/1] MR3730: comctl32: Use iswalnum() to filter alpha numeric characters from unicode messages. - approved

[Zhiyi Zhang (＠zhiyi)]

This merge request was approved by Zhiyi Zhang.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3730

[Nikolay Sivov (＠nsivov)]

This could use a bug reference or some brief explanation.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3730#note_44312

[Dmitry Timoshkov (＠dmitry)]

> This could use a bug reference or some brief explanation.

This patch fixes navigation with keyboard in the list that has items
containing not english strings.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3730#note_44467

[PATCH 0/1] MR3730: comctl32: Use iswalnum() to filter alpha numeric characters from unicode messages. - approved

[Nikolay Sivov (＠nsivov)]

This merge request was approved by Nikolay Sivov.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3730