Re: [PATCH v2 0/1] MR2359: opengl32: fix bug abort missing convert of glUmapBuffer_params from 32bit to 64bit
Rémi Bernon (@rbernon) commented about dlls/opengl32/unix_wgl.c:
} *params32 = args; NTSTATUS status; TEB *teb = get_teb64( params32->teb ); + struct glUnmapBuffer_params params = { teb, params32->target, params32->ret };
if (!(ptr = get_buffer_pointer( teb, params32->target ))) return STATUS_SUCCESS;
status = wow64_unmap_buffer( ptr, get_buffer_param( teb, params32->target, GL_BUFFER_MAP_LENGTH ), get_buffer_param( teb, params32->target, GL_BUFFER_ACCESS_FLAGS ) ); - gl_unmap_buffer64( args ); + gl_unmap_buffer64( ¶ms );
```suggestion:-8+0 struct glUnmapBuffer_params params = { .teb = get_teb64(params32->teb), .target = params32->target, .ret = TRUE, }; NTSTATUS status; if (!(ptr = get_buffer_pointer( params.teb, params.target ))) return STATUS_SUCCESS; status = wow64_unmap_buffer( ptr, get_buffer_param( params.teb, params.target, GL_BUFFER_MAP_LENGTH ), get_buffer_param( params.teb, params.target, GL_BUFFER_ACCESS_FLAGS ) ); gl_unmap_buffer64( ¶ms ); params32->ret = params.ret; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2359#note_26526
participants (1)
-
Rémi Bernon