[PATCH 0/1] MR6425: Draft: include: Name parameters in LPPROGRESS_ROUTINE typedef

[Ostap Brehin (＠osbre)]

Source: https://learn.microsoft.com/en-us/windows/win32/api/winbase/nc-winbase-lppro...

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6425

[PATCH 1/1] include: Name parameters in LPPROGRESS_ROUTINE typedef

[Ostap Brehin]

From: Ostap Brehin <osbre(a)protonmail.com>

---
 include/winbase.h | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/include/winbase.h b/include/winbase.h
index fe143cc7a61..02eb6969edc 100644
--- a/include/winbase.h
+++ b/include/winbase.h
@@ -1035,9 +1035,17 @@ typedef struct _WIN32_FILE_ATTRIBUTES_DATA {
  * This one seems to be a Win32 only definition. It also is defined with
  * WINAPI instead of CALLBACK in the windows headers.
  */
-typedef DWORD (CALLBACK *LPPROGRESS_ROUTINE)(LARGE_INTEGER, LARGE_INTEGER, LARGE_INTEGER,
-                                           LARGE_INTEGER, DWORD, DWORD, HANDLE,
-                                           HANDLE, LPVOID);
+typedef DWORD (WINAPI *LPPROGRESS_ROUTINE)(
+    LARGE_INTEGER TotalFileSize, 
+    LARGE_INTEGER TotalBytesTransferred, 
+    LARGE_INTEGER StreamSize, 
+    LARGE_INTEGER StreamBytesTransferred, 
+    DWORD dwStreamNumber, 
+    DWORD dwCallbackReason, 
+    HANDLE hSourceFile,
+    HANDLE hDestinationFile, 
+    LPVOID lpData
+);
 
 typedef DWORD (WINAPI *APPLICATION_RECOVERY_CALLBACK)(PVOID);
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6425

[PATCH 0/1] MR6425: include: Name parameters in LPPROGRESS_ROUTINE typedef

[Nikolay Sivov (＠nsivov)]

Could you explain the purpose of this change?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6425#note_80835

[PATCH 0/1] MR6425: include: Name parameters in LPPROGRESS_ROUTINE typedef

[Alfred Agrell (＠Alcaro)]

On Tue Sep  3 10:04:23 2024 +0000, Nikolay Sivov wrote:
> Could you explain the purpose of this change?
> One benefit of this change is better IDE autocomplete.

I agree with naming the parameters, though I'm not sure why CALLBACK is being changed to WINAPI; it is a callback.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6425#note_80836