[PATCH 0/1] MR4419: msado15: Updating recordset EditMode when field value changes

[Alistair Leslie-Hughes (＠alesliehughes)]

We need to know what type of Edit we are Performing, eg AddNew or Updated existing.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4419

[PATCH 1/1] msado15: Updating recordset EditMode when field value changes

[Alistair Leslie-Hughes]

From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>

We need to know what type of Edit we are Performing, eg AddNew or Updated existing.
---
 dlls/msado15/recordset.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/dlls/msado15/recordset.c b/dlls/msado15/recordset.c
index 2b936f5c096..d64ccdeee3d 100644
--- a/dlls/msado15/recordset.c
+++ b/dlls/msado15/recordset.c
@@ -298,6 +298,10 @@ static HRESULT WINAPI field_put_Value( Field *iface, VARIANT val )
     if ((hr = VariantCopy( ©, &val )) != S_OK) return hr;
 
     field->recordset->data[row * col_count + col] = copy;
+
+    if (field->recordset->editmode != adEditNone)
+        field->recordset->editmode = adEditInProgress;
+
     return S_OK;
 }
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4419

[PATCH 1/1] msado15: Updating recordset EditMode when field value changes

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=140000

Your paranoid android.


=== debian11 (32 bit report) ===

msado15:
msado15.c:327: Test failed: got 1
msado15.c:335: Test failed: got 1

=== debian11b (64 bit WoW report) ===

dinput:
device8.c:2238: Test failed: 0x700: got key_state[0] 0

msado15:
msado15.c:327: Test failed: got 1
msado15.c:335: Test failed: got 1

Report validation errors:
mfmediaengine:mfmediaengine crashed (80000101)