[PATCH v2 0/1] MR7154: dlls/mshtml/mshtml.inf: add registry associations for .log files
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=25872 -- v2: dlls/mshtml/mshtml.inf: add registry associations for .log files https://gitlab.winehq.org/wine/wine/-/merge_requests/7154
From: Austin English <austinenglish(a)gmail.com> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=25872 --- dlls/mshtml/mshtml.inf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/mshtml/mshtml.inf b/dlls/mshtml/mshtml.inf index 3e05d849fe3..4b3ccf26382 100644 --- a/dlls/mshtml/mshtml.inf +++ b/dlls/mshtml/mshtml.inf @@ -278,6 +278,8 @@ HKCR,".tiff","Content Type",,"image/tiff" HKCR,"MIME\Database\Content Type\text/plain","CLSID",,"%CLSID_HTMLDocument%" HKCR,"MIME\Database\Content Type\text/plain","Extension",,".txt" HKCR,"MIME\Database\Content Type\text/plain","Encoding",1,07,00,00,00 +HKCR,".log",,,"txtfile" +HKCR,".log","Content Type",,"text/plain" HKCR,".txt",,,"txtfile" HKCR,".txt","Content Type",,"text/plain" -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/7154
On Thu Feb 6 08:00:30 2025 +0000, Austin English wrote:
changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/7154/diffs?diff_id=156001&start_sha=a624dee3e0eb09b564ae040916b2cd8c8aa35452#0ef6242d879e1a4c67036d80705c632ad82a7261_281_281) Updated, thanks for the review!
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7154#note_93836
This merge request was approved by Alex Henrie. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7154
Jacek Caban (@jacek) commented about dlls/mshtml/mshtml.inf:
HKCR,"MIME\Database\Content Type\text/plain","CLSID",,"%CLSID_HTMLDocument%" HKCR,"MIME\Database\Content Type\text/plain","Extension",,".txt" HKCR,"MIME\Database\Content Type\text/plain","Encoding",1,07,00,00,00 +HKCR,".log",,,"txtfile" +HKCR,".log","Content Type",,"text/plain" Where does it come from? On Windows 10, I can see only the default value ("txtfile"), but not "Content Type". On Windows 11, there is "OpenWithProgids" subkey, but no other values.
Also please use more canonical commit message. "mshtml:" is enough for the prefix, uppercase "Add...", see git log for examples. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7154#note_94174
On Mon Feb 10 19:47:04 2025 +0000, Jacek Caban wrote:
Where does it come from? On Windows 10, I can see only the default value ("txtfile"), but not "Content Type". On Windows 11, there is "OpenWithProgids" subkey, but no other values. Also please use more canonical commit message. "mshtml:" is enough for the prefix, uppercase "Add...", see git log for examples. Good point. It isn't strictly necessary to add a "Content Type" value; I think Austin was just copying and pasting from the other instance of `txtfile`. This commit could just be the 1-line addition that fixes [Bug 25872](https://bugs.winehq.org/show_bug.cgi?id=25872).
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7154#note_94218
participants (4)
-
Alex Henrie (＠alexhenrie) -
Austin English
-
Austin English (＠austin987)
-
Jacek Caban (＠jacek)