[PATCH 0/1] MR7628: win32u: Return 0 from NtUserGetKeyNameText if there is no translation.

[Attila Fidan (＠atticf)]

The Kirikiri Z [menu](https://github.com/krkrz/menu/blob/master/Main.cpp) plugin causes an exception to be raised (and the engine unloads the DLL) if GetKeyNameText returns a length of 1 with a null character. The affected applications later fail with script exception dialogs as menu.dll was unloaded.

When using winex11 (and presumably winemac), the function returns the return value of the driver function for GetKeyNameText, and that returns 0 on an unsupported key which works. On winewayland (and the null driver), that isn't implemented, and instead the function continues and calls NtUserMapVirtualKeyEx with MAPVK_VK_TO_CHAR filling the buffer with one character which is 0 (no translation). The function then returns 1 for that null character and the applications don't seem to handle that well.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7628

[PATCH 1/1] win32u: Return 0 from NtUserGetKeyNameText if there is no translation.

[Attila Fidan]

From: Attila Fidan <dev(a)print0.net>

---
 dlls/win32u/input.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/win32u/input.c b/dlls/win32u/input.c
index ad4ba4d77c5..e1a0b11a584 100644
--- a/dlls/win32u/input.c
+++ b/dlls/win32u/input.c
@@ -1269,7 +1269,7 @@ INT WINAPI NtUserGetKeyNameText( LONG lparam, WCHAR *buffer, INT size )
         HKL hkl = NtUserGetKeyboardLayout( 0 );
         vkey = NtUserMapVirtualKeyEx( code & 0xff, MAPVK_VSC_TO_VK, hkl );
         buffer[0] = NtUserMapVirtualKeyEx( vkey, MAPVK_VK_TO_CHAR, hkl );
-        len = 1;
+        len = buffer[0] ? 1 : 0;
     }
     buffer[len] = 0;
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/7628

[PATCH 0/1] MR7628: win32u: Return 0 from NtUserGetKeyNameText if there is no translation. - approved

[Rémi Bernon]

This merge request was approved by Rémi Bernon.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7628