[PATCH 0/1] MR4594: dxgi/tests: Release the swapchain after waiting for the window thread to finish in test_resize_target_wndproc().

[Henri Verbeet (＠hverbeet)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4594

[PATCH 1/1] dxgi/tests: Release the swapchain after waiting for the window thread to finish in test_resize_target_wndproc().

[Henri Verbeet]

From: Henri Verbeet <hverbeet(a)codeweavers.com>

In order to prevent resize_target_wndproc() from potentially accessing the
swapchain after it has been destroyed.
---
 dlls/dxgi/tests/dxgi.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/dlls/dxgi/tests/dxgi.c b/dlls/dxgi/tests/dxgi.c
index f929a571823..35b89e94157 100644
--- a/dlls/dxgi/tests/dxgi.c
+++ b/dlls/dxgi/tests/dxgi.c
@@ -3523,12 +3523,6 @@ static void test_resize_target_wndproc(IUnknown *device, BOOL is_d3d12)
     hr = IDXGISwapChain_SetFullscreenState(swapchain, FALSE, NULL);
     ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr);
 
-    refcount = IDXGISwapChain_Release(swapchain);
-    ok(!refcount, "IDXGISwapChain has %lu references left.\n", refcount);
-
-    refcount = IDXGIFactory_Release(factory);
-    ok(refcount == !is_d3d12, "Got unexpected refcount %lu.\n", refcount);
-
     ret = SetEvent(thread_data.finished);
     ok(ret, "Failed to set event, last error %#lx.\n", GetLastError());
     ret = WaitForSingleObject(thread, INFINITE);
@@ -3536,6 +3530,12 @@ static void test_resize_target_wndproc(IUnknown *device, BOOL is_d3d12)
     CloseHandle(thread);
     CloseHandle(thread_data.window_created);
     CloseHandle(thread_data.finished);
+
+    refcount = IDXGISwapChain_Release(swapchain);
+    ok(!refcount, "IDXGISwapChain has %lu references left.\n", refcount);
+
+    refcount = IDXGIFactory_Release(factory);
+    ok(refcount == !is_d3d12, "Got unexpected refcount %lu.\n", refcount);
 }
 
 static void test_inexact_modes(void)
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4594

[PATCH 0/1] MR4594: dxgi/tests: Release the swapchain after waiting for the window thread to finish in test_resize_target_wndproc(). - approved

[Zebediah Figura (＠zfigura)]

This merge request was approved by Zebediah Figura.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4594

[PATCH 0/1] MR4594: dxgi/tests: Release the swapchain after waiting for the window thread to finish in test_resize_target_wndproc(). - approved

[Jan Sikorski (＠jsikorski)]

This merge request was approved by Jan Sikorski.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4594