Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.
Zebediah Figura (@zfigura) commented about dlls/wmvcore/async_reader.c:
+ continue; + } + + while (stream->read_requested) + { + stream->read_requested = false; + + if (sample->buffer) + INSSBuffer_Release(sample->buffer); + sample->buffer = NULL; + + LeaveCriticalSection(&reader->callback_cs); + hr = IWMSyncReader2_GetNextSample(reader->reader, stream->number, + &sample->buffer, &sample->pts, &sample->duration, + &sample->flags, &sample->output, &sample->stream); + EnterCriticalSection(&reader->callback_cs); Similarly to the earlier question about IWMSyncReader locking, do we need to drop the CS here?
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311#note_15864
participants (1)
-
Zebediah Figura (@zfigura)