[PATCH v2 0/2] MR4175: uxtheme: Add stub for SetPreferredAppMode.

[Louis Lenders (＠xe)]

Wine bug: https://bugs.winehq.org/show_bug.cgi?id=55742

--
  v2: uxtheme: Add stub for SetPreferredAppMode.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4175

[PATCH v2 1/2] uxtheme: Add stub for SetPreferredAppMode.

[Louis Lenders]

From: Louis Lenders <xerox.xerox2000x(a)gmail.com>

Wine bug: https://bugs.winehq.org/show_bug.cgi?id=55742
---
 dlls/uxtheme/system.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/dlls/uxtheme/system.c b/dlls/uxtheme/system.c
index f1a4d0d5566..6b202bb48a7 100644
--- a/dlls/uxtheme/system.c
+++ b/dlls/uxtheme/system.c
@@ -1290,3 +1290,13 @@ BOOL WINAPI ShouldAppsUseDarkMode(void)
 
     return !light_theme;
 }
+
+/**********************************************************************
+ *      SetPreferredAppMode                             (UXTHEME.135)
+ *
+ */
+int WINAPI SetPreferredAppMode(int app_mode)
+{
+    FIXME("%d: stub\n", app_mode);
+    return 0;
+}
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/4175

[PATCH v2 2/2] uxtheme: Add stub for SetPreferredAppMode.

[Louis Lenders]

From: Louis Lenders <xerox.xerox2000x(a)gmail.com>

https://bugs.winehq.org/show_bug.cgi?id=55742
---
 dlls/uxtheme/system.c     | 2 +-
 dlls/uxtheme/uxtheme.spec | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/uxtheme/system.c b/dlls/uxtheme/system.c
index 6b202bb48a7..7d19cfbc510 100644
--- a/dlls/uxtheme/system.c
+++ b/dlls/uxtheme/system.c
@@ -1298,5 +1298,5 @@ BOOL WINAPI ShouldAppsUseDarkMode(void)
 int WINAPI SetPreferredAppMode(int app_mode)
 {
     FIXME("%d: stub\n", app_mode);
-    return 0;
+    return app_mode;
 }
diff --git a/dlls/uxtheme/uxtheme.spec b/dlls/uxtheme/uxtheme.spec
index d31621e11a7..6bcebffe0a5 100644
--- a/dlls/uxtheme/uxtheme.spec
+++ b/dlls/uxtheme/uxtheme.spec
@@ -43,6 +43,7 @@
 62 stub -noname ServerClearStockObjects
 63 stub -noname MarkSelection
 132 stdcall -noname ShouldAppsUseDarkMode()
+135 stdcall -noname SetPreferredAppMode(long)
 138 stdcall -noname ShouldSystemUseDarkMode()
 
 # Standard functions
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4175

[Zhiyi Zhang (＠zhiyi)]

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/system.c:
> int WINAPI SetPreferredAppMode(int app_mode)
>  {
>      FIXME("%d: stub\n", app_mode);
> -    return 0;
> +    return app_mode;
> Does the app depend on specific return values? If not, you can just return 0;

Please merge these two commits together.

Also, in the commit message, you should use the Wine-Bug: tag.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4175#note_49809