Re: [PATCH v6 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
19 Oct
2022
19 Oct
'22
9:52 a.m.
On Wed Oct 19 09:30:33 2022 +0000, Patrick Hibbs wrote:
changed this line in [version 5 of the diff](/wine/wine/-/merge_requests/979/diffs?diff_id=14510&start_sha=9be4873a7477520f0eb74837f2a269f864a9ac13#6af8d13245d87d86339fd93c308f9d2332f22092_9077_9004) Actually it seems that the strings are rendered irretrievable by the call to SetRawValue().
Calling GetString() on a scalar string after the destruction causes a crash in win10. While calling it with a string vector doesn't crash, but returns D3DERR_INVALIDCALL instead. I've updated the tests in v3 of the patch to check for this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/979#note_11290
1233
Age (days ago)
1233
Last active (days ago)
0 comments
1 participants
participants (1)
-
Patrick Hibbs (@hibbsncc1701)