[PATCH v2 0/1] MR2867: imm32: Don't erroneously start composition when handling IMC_SETOPENSTATUS.
-- v2: imm32: Don't erroneously start composition when handling IMC_SETOPENSTATUS. https://gitlab.winehq.org/wine/wine/-/merge_requests/2867
From: Jinoh Kang <jinoh.kang.kr(a)gmail.com> Fixes: 8ae0c308233e61cfc01ef52886077960d6513d93 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54965 --- dlls/imm32/ime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/imm32/ime.c b/dlls/imm32/ime.c index 10fd234a2c1..e15367f5fa8 100644 --- a/dlls/imm32/ime.c +++ b/dlls/imm32/ime.c @@ -657,7 +657,7 @@ BOOL WINAPI NotifyIME( HIMC himc, DWORD action, DWORD index, DWORD value ) if (!ctx->fOpen) { input_context_set_comp_str( ctx, NULL, 0 ); - if ((msg = ime_set_composition_status( himc, TRUE ))) ime_send_message( himc, msg, 0, 0 ); + if ((msg = ime_set_composition_status( himc, FALSE ))) ime_send_message( himc, msg, 0, 0 ); } NtUserNotifyIMEStatus( ctx->hWnd, ctx->fOpen ); break; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/2867
v1 -> v2: add `Wine-Bug:` trailer to commit message -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2867#note_33344
Probably `s/start/stop/`, otherwise looks good. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2867#note_33357
On Mon May 22 07:57:29 2023 +0000, Rémi Bernon wrote:
Probably `s/start/stop/`, otherwise looks good. Actually no. Nvm.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2867#note_33358
This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2867
participants (3)
-
Jinoh Kang -
Jinoh Kang (＠iamahuman)
-
Rémi Bernon