[PATCH 0/1] MR3633: winegstreamer: Don't append videconvert for video/x-wmv output.

[Rémi Bernon]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3633

[PATCH 1/1] winegstreamer: Don't append videconvert for video/x-wmv output.

[Rémi Bernon]

From: Rémi Bernon <rbernon(a)codeweavers.com>

---
 dlls/winegstreamer/wg_transform.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/dlls/winegstreamer/wg_transform.c b/dlls/winegstreamer/wg_transform.c
index 775fed7a46c..858dd7cc404 100644
--- a/dlls/winegstreamer/wg_transform.c
+++ b/dlls/winegstreamer/wg_transform.c
@@ -401,7 +401,6 @@ NTSTATUS wg_transform_create(void *args)
             break;
 
         case WG_MAJOR_TYPE_VIDEO:
-        case WG_MAJOR_TYPE_VIDEO_WMV:
             if (!(element = create_element("videoconvert", "base"))
                     || !append_element(transform->container, element, &first, &last))
                 goto out;
@@ -418,12 +417,15 @@ NTSTATUS wg_transform_create(void *args)
             gst_util_set_object_arg(G_OBJECT(element), "n-threads", "0");
             break;
 
+        case WG_MAJOR_TYPE_VIDEO_WMV:
+            break;
+
+        case WG_MAJOR_TYPE_UNKNOWN:
         case WG_MAJOR_TYPE_AUDIO_MPEG1:
         case WG_MAJOR_TYPE_AUDIO_MPEG4:
         case WG_MAJOR_TYPE_AUDIO_WMA:
         case WG_MAJOR_TYPE_VIDEO_CINEPAK:
         case WG_MAJOR_TYPE_VIDEO_H264:
-        case WG_MAJOR_TYPE_UNKNOWN:
         case WG_MAJOR_TYPE_VIDEO_INDEO:
             GST_FIXME("Format %u not implemented!", output_format.major_type);
             goto out;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/3633

[Zebediah Figura (＠zfigura)]

What problem is this solving?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3633#note_43047

[Rémi Bernon]

On Tue Aug 22 16:38:38 2023 +0000, Zebediah Figura wrote:
> What problem is this solving?
> It's not solving anything, it's just incorrect. We don't want to append videoconvert/videoflip when outputting wmv (although right now this doesn't really do anything).

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3633#note_43053

[Zebediah Figura (＠zfigura)]

> It's not solving anything, it's just incorrect. We don't want to append videoconvert/videoflip when outputting wmv (although right now this doesn't really do anything).

Ah yes, sorry, I misread what this patch was doing.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3633#note_43133

[PATCH 0/1] MR3633: winegstreamer: Don't append videconvert for video/x-wmv output. - approved

[Zebediah Figura (＠zfigura)]

This merge request was approved by Zebediah Figura.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/3633