[PATCH 0/1] MR9345: d2d1: Fix missing geometry assignment in command list recording

[Yeshun Ye (＠yeyeshun)]

The d2d_command_list_draw_geometry() function didn't store the 'geometry',
this may cause an error when command replay.

Signed-off-by: YeshunYe <yeyeshun(a)uniontech.com>

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9345

[PATCH 1/1] d2d1: Fix missing geometry assignment in command list recording

[YeshunYe]

From: YeshunYe <yeyeshun(a)uniontech.com>

The d2d_command_list_draw_geometry() function didn't store the 'geometry',
this may cause an error when command replay.

Signed-off-by: YeshunYe <yeyeshun(a)uniontech.com>
---
 dlls/d2d1/command_list.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/d2d1/command_list.c b/dlls/d2d1/command_list.c
index 27c2bf3db41..e19234860a4 100644
--- a/dlls/d2d1/command_list.c
+++ b/dlls/d2d1/command_list.c
@@ -798,6 +798,7 @@ void d2d_command_list_draw_geometry(struct d2d_command_list *command_list,
     command->brush = brush;
     command->stroke_width = stroke_width;
     command->stroke_style = stroke_style;
+    command->geometry = geometry;
 }
 
 void d2d_command_list_draw_rectangle(struct d2d_command_list *command_list, const struct d2d_device_context *context,
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/9345

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/d2d1/command_list.c:
> command->brush = brush;
>      command->stroke_width = stroke_width;
>      command->stroke_style = stroke_style;
> +    command->geometry = geometry;
>  }

The fix is good, but please move this before 'brush' assignment to keep everything in argument order.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9345#note_120434