[PATCH 0/1] MR1749: mshtml: Add head, title and body elements to about:blank.
From: Santino Mazza <smazza(a)codeweavers.com> --- dlls/mshtml/blank.htm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/mshtml/blank.htm b/dlls/mshtml/blank.htm index 8c17451f917..2898ada39b0 100644 --- a/dlls/mshtml/blank.htm +++ b/dlls/mshtml/blank.htm @@ -1 +1 @@ -<HTML></HTML> +<HTML><HEAD><TITLE></TITLE></HEAD><BODY></BODY></HTML> -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/1749
Some tests would be nice, or at least, some context why this is correct? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1749#note_19197
Sorry. I found that the about:blank page in windows has 4 elements and in wine it has 3, when I enumerated all of them I found that it has HTML, HEAD, TITLE and BODY elements, I'm working in some tests, do I have to test for each element inside of about:blank or by just testing for the amount of elements it's fine? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1749#note_19247
On Fri Dec 9 01:07:35 2022 +0000, Santino Mazza wrote:
Sorry. I found that the about:blank page in windows has 4 elements and in wine it has 3, when I enumerated all of them I found that it has HTML, HEAD, TITLE and BODY elements, I'm working in some tests, do I have to test for each element inside of about:blank or by just testing for the amount of elements it's fine? Note that the file that you modify is not used by about:blank protocol handler. See `AboutProtocol_Start` for how about: protocol works. Essentially, about:blank is always just '<HTML></HTML>' and we have tests for that. I guess that what you observe is a difference between how Gecko and IE handles absence <head> and <body> elements. Maybe IE adds implicit <title> in this case or something along those lines.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1749#note_19258
On Fri Dec 9 01:07:35 2022 +0000, Jacek Caban wrote:
Note that the file that you modify is not used by about:blank protocol handler. See `AboutProtocol_Start` for how about: protocol works. Essentially, about:blank is always just '<HTML></HTML>' and we have tests for that. I guess that what you observe is a difference between how Gecko and IE handles absence <head> and <body> elements. Maybe IE adds implicit <title> in this case or something along those lines. Ohh it could be, actually, when I open about:blank with the internet explorer app it creates 3 elements, HTML, HEAD and BODY (as gecko does), but if you open about:blank with the mshtml api (as it does when it calls test_put_href with about:blank as parameter in mshtml/tests/htmldoc.c) and call IHTMLDocument2_get_all it will retrieve you an element collection with 4 elements, HTML, HEAD, TITLE and BODY.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1749#note_19329
This merge request was closed by Santino Mazza. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1749
participants (4)
-
Gabriel Ivăncescu -
Jacek Caban (＠jacek)
-
Santino Mazza
-
Santino Mazza (＠tati1454)