[PATCH 0/1] MR6172: kernel32: Add SetFirmwareEnvironmentVariableA stub.

[Fabian Maurer (＠DarkShadow44)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57012

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6172

[PATCH 1/1] kernel32: Add SetFirmwareEnvironmentVariableA stub.

[Fabian Maurer]

From: Fabian Maurer <dark.shadow4(a)web.de>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57012
---
 dlls/kernel32/kernel32.spec |  2 +-
 dlls/kernel32/process.c     | 10 ++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec
index 179d49ba7cb..c7fe7d7724e 100644
--- a/dlls/kernel32/kernel32.spec
+++ b/dlls/kernel32/kernel32.spec
@@ -1437,7 +1437,7 @@
 # @ stub SetFileShortNameW
 @ stdcall -import SetFileTime(long ptr ptr ptr)
 @ stdcall -import SetFileValidData(ptr int64)
-# @ stub SetFirmwareEnvironmentVariableA
+@ stdcall SetFirmwareEnvironmentVariableA(str str ptr long)
 @ stdcall SetFirmwareEnvironmentVariableW(wstr wstr ptr long)
 @ stdcall SetHandleContext(long long)
 @ stdcall SetHandleCount(long)
diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c
index d56118a0fe3..2a4ddc68f02 100644
--- a/dlls/kernel32/process.c
+++ b/dlls/kernel32/process.c
@@ -738,6 +738,16 @@ DWORD WINAPI GetFirmwareEnvironmentVariableW(LPCWSTR name, LPCWSTR guid, PVOID b
     return 0;
 }
 
+/***********************************************************************
+ *           SetFirmwareEnvironmentVariableA     (KERNEL32.@)
+ */
+BOOL WINAPI SetFirmwareEnvironmentVariableA(const char *name, const char *guid, void *buffer, DWORD size)
+{
+    FIXME("stub: %s %s %p %lu\n", debugstr_a(name), debugstr_a(guid), buffer, size);
+    SetLastError(ERROR_INVALID_FUNCTION);
+    return FALSE;
+}
+
 /***********************************************************************
  *           SetFirmwareEnvironmentVariableW     (KERNEL32.@)
  */
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6172

[PATCH 1/1] kernel32: Add SetFirmwareEnvironmentVariableA stub.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=147418

Your paranoid android.


=== debian11b (64 bit WoW report) ===

user32:
input.c:4305: Test succeeded inside todo block: button_down_hwnd_todo 1: got MSG_TEST_WIN hwnd 00000000005C00E8, msg WM_LBUTTONDOWN, wparam 0x1, lparam 0x320032