[PATCH 0/1] MR5427: Update SCROLL_MIN_THUMB to make wider

[Sam Joan Roque-Worcel (＠Joan)]

Addresses this bug: https://bugs.winehq.org/show_bug.cgi?id=54759

This is how the vertical scrollbar looks after the patch is applied:

![after](/uploads/ed2437c8aaddbb0eea0058f9dfbb5f1f/after.JPG)

And this is a comparison between windows 10 and Wine:

![same](/uploads/09c29f2976cb1a10511d9b6eee18b07c/same.JPG)

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5427

[PATCH 1/1] Update SCROLL_MIN_THUMB to make wider

[Joan]

From: Joan <sam(a)roque-worcel.com>

---
 dlls/win32u/scroll.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/win32u/scroll.c b/dlls/win32u/scroll.c
index 19a9a1379f4..ab32d6870d3 100644
--- a/dlls/win32u/scroll.c
+++ b/dlls/win32u/scroll.c
@@ -36,7 +36,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(scroll);
 #define SCROLL_MIN_RECT  4
 
 /* Minimum size of the thumb in pixels */
-#define SCROLL_MIN_THUMB 8
+#define SCROLL_MIN_THUMB 24
 
 /* Overlap between arrows and thumb */
 #define SCROLL_ARROW_THUMB_OVERLAP 0
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/5427

[PATCH 1/1] Update SCROLL_MIN_THUMB to make wider

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=144511

Your paranoid android.


=== debian11b (64 bit WoW report) ===

user32:
input.c:3875: Test succeeded inside todo block: button_down_hwnd_todo 1: got MSG_TEST_WIN hwnd 00000000005900EE, msg WM_LBUTTONDOWN, wparam 0x1, lparam 0x320032

[PATCH 0/1] MR5427: win32u: Make SCROLL_MIN_THUMB larger.

[Stefan Dösinger]

Changes like these usually lead to the question where the current value comes from and why the new value is the right thing to do now.

I had a look at Windows 95 (thanks to pcjs.org), and it seems it has an 8 pixel minimum slider size. This is still the case on unthemed Windows XP ("windows classic"). The standard Windows XP theme makes it slightly larger, but not by much. Windows 11 on the other hand has a noticeably larger minimum slider size. All those were tested in plain notepad.exe.

My 2c is that the larger slider is a usability improvement on modern screens. It is easier to grab with the mouse. The smaller slider probably made it easier to place the scroll position accurately on low resolutions like 640x480 or 800x600, which were common during Win9x times.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5427#note_66541

[PATCH 0/1] MR5427: win32u: Make SCROLL_MIN_THUMB larger.

[Zhiyi Zhang (＠zhiyi)]

Please change the subject to "win32u: Make SCROLL_MIN_THUMB larger." and add a "Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54759" in the commit message body. Other than that, this looks good to me. Thanks for looking into this.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5427#note_66556

[PATCH 0/1] MR5427: win32u: Make SCROLL_MIN_THUMB larger.

[Zhiyi Zhang (＠zhiyi)]

Also, the exact value on Windows 10 is 17 when the DPI is 96. So let's use 17 instead.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5427#note_66558