[PATCH 0/1] MR7902: krnl386: Add FIXME case for every unimplemented DPMI 0.9 call
Windows provides DPMI host according to DPMI version 0.9. Add cases for all missing DPMI 0.9 function calls into wine code, set Carry flag which indicates DPMI failure and mark them with appropriate FIXME comments. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7902
From: Pali Rohár <pali(a)kernel.org> Windows provides DPMI host according to DPMI version 0.9. Add cases for all missing DPMI 0.9 function calls into wine code, set Carry flag which indicates DPMI failure and mark them with appropriate FIXME comments. Signed-off-by: Pali Rohár <pali(a)kernel.org> --- dlls/krnl386.exe16/int31.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/dlls/krnl386.exe16/int31.c b/dlls/krnl386.exe16/int31.c index 0d13763451c..fa7951946ad 100644 --- a/dlls/krnl386.exe16/int31.c +++ b/dlls/krnl386.exe16/int31.c @@ -639,6 +639,31 @@ void WINAPI DOSVM_Int31Handler( CONTEXT *context ) TRACE( "Get Virtual Interrupt State - not supported\n" ); break; + case 0x0a00: /* Get Vendor-Specific API Entry Point */ + FIXME( "Get Vendor-Specific API Entry Point - unimplemented\n" ); + SET_CFLAG( context ); + break; + + case 0x0b00: /* Set Debug Watchpoint */ + FIXME( "Set Debug Watchpoint - unimplemented\n" ); + SET_CFLAG( context ); + break; + + case 0x0b01: /* Clear Debug Watchpoint */ + FIXME( "Clear Debug Watchpoint - unimplemented\n" ); + SET_CFLAG( context ); + break; + + case 0x0b02: /* Get State of Debug Watchpoint */ + FIXME( "Get State of Debug Watchpoint - unimplemented\n" ); + SET_CFLAG( context ); + break; + + case 0x0b03: /* Reset Debug Watchpoint */ + FIXME( "Reset Debug Watchpoint - unimplemented\n" ); + SET_CFLAG( context ); + break; + case 0x0e00: /* Get Coprocessor Status (1.0) */ /* * Return status in AX bits: -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/7902
This merge request was closed by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7902
The generic error path already handles this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7902#note_113242
On Sat Aug 30 08:13:19 2025 +0000, Alexandre Julliard wrote:
The generic error path already handles this. Unfortunately generic error path does not show readable information in debug trace what function is not implemented. And this information is needed for debugging.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7902#note_114269
On Sat Aug 30 08:13:19 2025 +0000, Pali Rohár wrote:
Unfortunately generic error path does not show readable information in debug trace what function is not implemented. And this information is needed for debugging. The generic error path shows enough information to investigate the issue, if it ever becomes necessary to debug it.
These functions have been in their present state for over 20 years, and it has never been a problem. It's safe to say that it will never be a problem. Please let's spend our efforts on things that actually matter. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7902#note_114296
participants (2)
-
Alexandre Julliard (＠julliard) -
Pali Rohár