Re: [PATCH v2 0/3] MR8946: widl: Add metadata support for imported types.

[Rémi Bernon]

Rémi Bernon (@rbernon) commented about tools/widl/metadata.c:
> add_constructor_overload( type );
>
> -    scope = resolution_scope( TABLE_ASSEMBLYREF, MSCORLIB_ROW );
> -    typeref = add_typeref_row( scope, add_string("Object"), add_string("System") );
> -    extends = typedef_or_ref( TABLE_TYPEREF, typeref );
> -
>      flags = TYPE_ATTR_PUBLIC | TYPE_ATTR_UNKNOWN;
>      if (!is_attr( type->attrs, ATTR_COMPOSABLE )) flags |= TYPE_ATTR_SEALED;
>      if (!iface_list) flags |= TYPE_ATTR_ABSTRACT;
>
> +    scope = resolution_scope( TABLE_ASSEMBLYREF, MSCORLIB_ROW );
> +    typeref = add_typeref_row( scope, add_string("Object"), add_string("System") );
> +    extends = typedef_or_ref( TABLE_TYPEREF, typeref );
> +
>      type->md.def = add_typedef_row( flags, name, namespace, extends, 0, 0 );

Same here, it just moves lines around?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8946#note_117511