[PATCH 0/1] MR9063: ntoskrnl.exe: Create keys for devices in HKEY_DYN_DATA\Config Manager\Enum.

[Elizabeth Figura (＠zfigura)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9063

[PATCH 1/1] ntoskrnl.exe: Create keys for devices in HKEY_DYN_DATA\Config Manager\Enum.

[Elizabeth Figura]

From: Elizabeth Figura <zfigura(a)codeweavers.com>

And populate their HardWareKey values.

This emulates Windows 9x architecture.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=7115
---
 dlls/ntoskrnl.exe/ntoskrnl_private.h |  1 +
 dlls/ntoskrnl.exe/pnp.c              | 47 ++++++++++++++++++++++++++++
 2 files changed, 48 insertions(+)

diff --git a/dlls/ntoskrnl.exe/ntoskrnl_private.h b/dlls/ntoskrnl.exe/ntoskrnl_private.h
index 472dc46fde3..d9db6f600ff 100644
--- a/dlls/ntoskrnl.exe/ntoskrnl_private.h
+++ b/dlls/ntoskrnl.exe/ntoskrnl_private.h
@@ -121,5 +121,6 @@ struct wine_device
 {
     DEVICE_OBJECT device_obj;
     DEVICE_RELATIONS *children;
+    HKEY dyn_data_key;
 };
 #endif
diff --git a/dlls/ntoskrnl.exe/pnp.c b/dlls/ntoskrnl.exe/pnp.c
index 1824fb28cab..9454d94fa3f 100644
--- a/dlls/ntoskrnl.exe/pnp.c
+++ b/dlls/ntoskrnl.exe/pnp.c
@@ -333,6 +333,42 @@ static BOOL install_device_driver( DEVICE_OBJECT *device, HDEVINFO set, SP_DEVIN
     return TRUE;
 }
 
+static void create_dyn_data_key( DEVICE_OBJECT *device )
+{
+    struct wine_device *wine_device = CONTAINING_RECORD(device, struct wine_device, device_obj);
+    WCHAR device_instance_id[MAX_DEVICE_ID_LEN];
+    static unsigned int counter;
+    WCHAR key_path[29];
+    DWORD disposition;
+    LSTATUS ret;
+    HKEY key;
+
+    if (get_device_instance_id( device, device_instance_id ))
+        return;
+
+    for (;;)
+    {
+        swprintf( key_path, ARRAY_SIZE(key_path), L"Config Manager\\Enum\\%08x", counter++ );
+
+        if ((ret = RegCreateKeyExW( HKEY_DYN_DATA, key_path, 0, NULL,
+                REG_OPTION_VOLATILE, KEY_ALL_ACCESS, NULL, &key, &disposition )))
+        {
+            ERR( "Failed to create %s, error %lu.\n", debugstr_w(key_path), GetLastError() );
+            return;
+        }
+
+        if (disposition == REG_CREATED_NEW_KEY)
+        {
+            RegSetValueExW( key, L"HardWareKey", 0, REG_SZ, (BYTE *)device_instance_id,
+                    wcslen( device_instance_id ) * sizeof(WCHAR) );
+            wine_device->dyn_data_key = key;
+            break;
+        }
+
+        RegCloseKey( key );
+    }
+}
+
 /* Load the function driver for a newly created PDO, if one is present, and
  * send IRPs to start the device. */
 static void start_device( DEVICE_OBJECT *device, HDEVINFO set, SP_DEVINFO_DATA *sp_device )
@@ -340,6 +376,8 @@ static void start_device( DEVICE_OBJECT *device, HDEVINFO set, SP_DEVINFO_DATA *
     load_function_driver( device, set, sp_device );
     if (device->DriverObject)
         send_pnp_irp( device, IRP_MN_START_DEVICE );
+
+    create_dyn_data_key( device );
 }
 
 static void enumerate_new_device( DEVICE_OBJECT *device, HDEVINFO set )
@@ -424,6 +462,15 @@ static void send_remove_device_irp( DEVICE_OBJECT *device, UCHAR code )
 
 static void remove_device( DEVICE_OBJECT *device )
 {
+    struct wine_device *wine_device = CONTAINING_RECORD(device, struct wine_device, device_obj);
+
+    if (wine_device->dyn_data_key)
+    {
+        RegDeleteKeyW( wine_device->dyn_data_key, L"" );
+        RegCloseKey( wine_device->dyn_data_key );
+        wine_device->dyn_data_key = 0;
+    }
+
     send_remove_device_irp( device, IRP_MN_SURPRISE_REMOVAL );
     send_remove_device_irp( device, IRP_MN_REMOVE_DEVICE );
 }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/9063

[Elizabeth Figura (＠zfigura)]

NT does not create these keys. A shim exists that can be downloaded for some versions of Windows that emulates them by hooking advapi32 registry APIs, but although it is created by Microsoft it is not shipped with Windows. I don't see a reason to emulate that architecture; simpler just to implement the 9x behaviour by creating real keys, since it does not conflict with any other behaviour anyway.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9063#note_116927

[Dmitry Timoshkov (＠dmitry)]

Dmitry Timoshkov (@dmitry) commented about dlls/ntoskrnl.exe/pnp.c:
> +        return;
> +
> +    for (;;)
> +    {
> +        swprintf( key_path, ARRAY_SIZE(key_path), L"Config Manager\\Enum\\%08x", counter++ );
> +
> +        if ((ret = RegCreateKeyExW( HKEY_DYN_DATA, key_path, 0, NULL,
> +                REG_OPTION_VOLATILE, KEY_ALL_ACCESS, NULL, &key, &disposition )))
> +        {
> +            ERR( "Failed to create %s, error %lu.\n", debugstr_w(key_path), GetLastError() );
> +            return;
> +        }
> +
> +        if (disposition == REG_CREATED_NEW_KEY)
> +        {
> +            RegSetValueExW( key, L"HardWareKey", 0, REG_SZ, (BYTE *)device_instance_id,
> Probably it's just me, but "HardwareKey" seems like a more natural capitalization style.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9063#note_116928

[Elizabeth Figura (＠zfigura)]

On Sun Sep 28 17:49:54 2025 +0000, Dmitry Timoshkov wrote:
> Probably it's just me, but "HardwareKey" seems like a more natural
> capitalization style.
> IIRC that's the capitalization Windows uses.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9063#note_116946

[PATCH 0/1] MR9063: ntoskrnl.exe: Create keys for devices in HKEY_DYN_DATA\Config Manager\Enum. - approved

[Elizabeth Figura (＠zfigura)]

This merge request was approved by Elizabeth Figura.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9063

[Alexandre Julliard (＠julliard)]

This is causing a bunch of FIXMEs with every app:

```
00ac:fixme:hid:fdo_pnp_dispatch Unhandled minor function 0x13.
00ac:fixme:hid:fdo_pnp_dispatch Unhandled minor function 0x13.
00ac:fixme:wineusb:fdo_pnp Unhandled minor function 0x13.
00ac:fixme:wineusb:fdo_pnp Unhandled minor function 0x13.
00ac:fixme:winebth:fdo_pnp Unhandled minor function IRP_MN_QUERY_ID.
00ac:fixme:winebth:fdo_pnp Unhandled minor function IRP_MN_QUERY_ID.
```

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9063#note_117180