[PATCH 0/5] MR6958: Silence unused variable warning in bison-generated files.
Continuation of !5704 for cases not covered by CI. As far as I can tell, these variables have been unused in all versions of Bison, but older versions of Clang (or other compilers) didn’t detect this, likely skipping the analysis due to the size or complexity of the generated code. When Clang started emitting warnings, upstream Bison partially addressed the issue by [marking the variables as unused](https://git.savannah.gnu.org/cgit/bison.git/commit/?id=a166d5450e3f47587b98f...). However, these markings remain ineffective in Clang MSVC mode due to hardcoded assumptions. My attempts to address this issue upstream in Bison have not received a response. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6958
From: Jacek Caban <jacek(a)codeweavers.com> --- dlls/jscript/cc_parser.y | 4 +++- dlls/jscript/parser.y | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/dlls/jscript/cc_parser.y b/dlls/jscript/cc_parser.y index 46354f479ee..0f6d4316c28 100644 --- a/dlls/jscript/cc_parser.y +++ b/dlls/jscript/cc_parser.y @@ -144,7 +144,9 @@ static int cc_parser_lex(void *lval, parser_ctx_t *ctx) /* FIXME: Implement missing expressions. */ CCExpr - : CCUnaryExpression { ctx->ccval = $1; YYACCEPT; } + : CCUnaryExpression { ctx->ccval = $1; + (void)cc_parser_nerrs; /* avoid unused variable warning */ + YYACCEPT; } CCUnaryExpression : tCCValue { $$ = $1; } diff --git a/dlls/jscript/parser.y b/dlls/jscript/parser.y index 156913bacf2..949d9131b80 100644 --- a/dlls/jscript/parser.y +++ b/dlls/jscript/parser.y @@ -251,7 +251,8 @@ static expression_t *new_prop_and_value_expression(parser_ctx_t*,property_list_t /* ECMA-262 10th Edition 15.1 */ Script - : ScriptBody HtmlComment { ctx->source = $1 ? $1->head : NULL; } + : ScriptBody HtmlComment { ctx->source = $1 ? $1->head : NULL; + (void)parser_nerrs; /* avoid unused variable warning */ } /* ECMA-262 10th Edition 15.1 */ ScriptBody -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/6958
From: Jacek Caban <jacek(a)codeweavers.com> --- dlls/msi/cond.y | 1 + dlls/msi/sql.y | 1 + 2 files changed, 2 insertions(+) diff --git a/dlls/msi/cond.y b/dlls/msi/cond.y index 49ad91ce049..678ea82c5fe 100644 --- a/dlls/msi/cond.y +++ b/dlls/msi/cond.y @@ -154,6 +154,7 @@ condition: { COND_input* cond = (COND_input*) info; cond->result = MSICONDITION_NONE; + (void)cond_nerrs; /* avoid unused variable warning */ } ; diff --git a/dlls/msi/sql.y b/dlls/msi/sql.y index 43425fa4afc..1b2af9e7919 100644 --- a/dlls/msi/sql.y +++ b/dlls/msi/sql.y @@ -115,6 +115,7 @@ query: { SQL_input* sql = (SQL_input*) info; *sql->view = $1; + (void)sql_nerrs; /* avoid unused variable warning */ } ; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/6958
From: Jacek Caban <jacek(a)codeweavers.com> --- dlls/msxml3/xslpattern.y | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/msxml3/xslpattern.y b/dlls/msxml3/xslpattern.y index b308c3150b0..549118aa7fe 100644 --- a/dlls/msxml3/xslpattern.y +++ b/dlls/msxml3/xslpattern.y @@ -84,6 +84,7 @@ static void xslpattern_error(parser_param* param, void const* scanner, char cons XSLPattern : Expr { p->out = $1; + (void)xslpattern_nerrs; /* avoid unused variable warning */ } ; -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/6958
From: Jacek Caban <jacek(a)codeweavers.com> --- dlls/vbscript/parser.y | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dlls/vbscript/parser.y b/dlls/vbscript/parser.y index 25b5ac513f3..caeaf25945c 100644 --- a/dlls/vbscript/parser.y +++ b/dlls/vbscript/parser.y @@ -178,7 +178,9 @@ GlobalDimDeclaration : tPRIVATE tCONST ConstDeclList { $$ = new_const_statement(ctx, @$, $3); CHECK_ERROR; } | tPUBLIC tCONST ConstDeclList { $$ = new_const_statement(ctx, @$, $3); CHECK_ERROR; } | tPRIVATE DimDeclList { $$ = new_dim_statement(ctx, @$, $2); CHECK_ERROR; } - | tPUBLIC DimDeclList { $$ = new_dim_statement(ctx, @$, $2); CHECK_ERROR; } + | tPUBLIC DimDeclList { $$ = new_dim_statement(ctx, @$, $2); + (void)parser_nerrs; /* avoid unused variable warning */ + CHECK_ERROR; } ExpressionNl_opt : /* empty */ { $$ = NULL; } -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/6958
From: Jacek Caban <jacek(a)codeweavers.com> --- dlls/wbemprox/wql.y | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/wbemprox/wql.y b/dlls/wbemprox/wql.y index d71475fc827..232aa657f41 100644 --- a/dlls/wbemprox/wql.y +++ b/dlls/wbemprox/wql.y @@ -302,6 +302,7 @@ associatorsof: #if YYBISON >= 30704 (void)yysymbol_name; /* avoid unused function warning */ #endif + (void)wql_nerrs; /* avoid unused variable warning */ } | TK_ASSOCIATORS TK_OF path TK_WHERE keywordlist { -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/6958
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=150209 Your paranoid android. === debian11b (64 bit WoW report) === user32: input.c:4305: Test succeeded inside todo block: button_down_hwnd_todo 1: got MSG_TEST_WIN hwnd 00000000006A00E0, msg WM_LBUTTONDOWN, wparam 0x1, lparam 0x320032
This merge request was approved by Hans Leidekker. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6958
This merge request was approved by Nikolay Sivov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6958
participants (5)
-
Hans Leidekker (＠hans) -
Jacek Caban
-
Jacek Caban (＠jacek)
-
Marvin -
Nikolay Sivov (＠nsivov)