[PATCH v2 0/1] MR7809: server: Do not call setpriority() if it cannot be used safely.

[Conor McCarthy (＠cmccarthy)]

Not checking nice_limit here can result in some calls to setpriority()
succeeding while others fail, which can result in relative priorities
being incorrect. For example, buffer underflows can occur in
winepulse.drv because the priority is too low in pulse_timer_loop().

--
  v2: server: Do not call setpriority() if it cannot be used safely.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7809

[PATCH v2 1/1] server: Do not call setpriority() if it cannot be used safely.

[Conor McCarthy]

From: Conor McCarthy <cmccarthy(a)codeweavers.com>

Not checking nice_limit here can result in some calls to setpriority()
succeeding while others fail, which can result in relative priorities
being incorrect. For example, buffer underflows can occur in
winepulse.drv because the priority is too low in pulse_timer_loop().
---
 server/thread.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/server/thread.c b/server/thread.c
index 27a40ce38ad..1eb3a610363 100644
--- a/server/thread.c
+++ b/server/thread.c
@@ -252,6 +252,9 @@ static void apply_thread_priority( struct thread *thread, int effective_priority
 {
     int min = -nice_limit, max = nice_limit, range = max - min, niceness;
 
+    if (nice_limit >= 0)
+        return;
+
     /* FIXME: handle realtime priorities using SCHED_RR if possible */
     if (effective_priority >= LOW_REALTIME_PRIORITY) effective_priority = LOW_REALTIME_PRIORITY - 1;
     /* map an NT application band [1,15] priority to [-nice_limit, nice_limit] */
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/7809