[PATCH 0/1] MR5408: Draft: debugging

[Esme Povirk (＠madewokherd)]

The Windows 11 message failure only seems to reproduce in a full test run, so we have to make an MR to investigate. I think it's clear with current results that just adjusting the expected sequence isn't going to be a solution.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5408

[PATCH 1/1] debugging

[Esme Povirk]

From: Esme Povirk <esme(a)codeweavers.com>

---
 dlls/user32/tests/msg.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c
index 473b4cfd4a1..0c84f881ded 100644
--- a/dlls/user32/tests/msg.c
+++ b/dlls/user32/tests/msg.c
@@ -2181,10 +2181,11 @@ static const struct message WmTrackPopupMenuMinimizeWindow[] = {
     { EVENT_SYSTEM_FOREGROUND, winevent_hook|wparam|lparam|optional, 0, 0 }, /* win11 */
     { WM_CANCELMODE, sent|optional }, /* not always sent on win11 */
     { EVENT_SYSTEM_CAPTUREEND, winevent_hook|wparam|lparam|winevent_hook_todo, 0, 0 },
-    { WM_CAPTURECHANGED, sent|defwinproc },
+    { WM_CAPTURECHANGED, sent },
     { EVENT_SYSTEM_MENUPOPUPEND, winevent_hook|wparam|lparam|winevent_hook_todo, OBJID_CLIENT, 0 },
     { HCBT_DESTROYWND, hook },
     { EVENT_OBJECT_HIDE, winevent_hook|wparam|lparam, 0, 0 },
+    { WM_ACTIVATEAPP, sent|wparam, 0 },
     { EVENT_OBJECT_DESTROY, winevent_hook|wparam|lparam|winevent_hook_todo, 0, 0 },
     { WM_UNINITMENUPOPUP, sent|defwinproc|lparam, 0, 0 },
     { WM_MENUSELECT, sent|defwinproc|wparam|lparam, 0xffff0000, 0 },
@@ -19862,6 +19863,16 @@ static void test_TrackPopupMenu(void)
     ok_sequence( WmTrackPopupMenuMinimizeWindow, "TrackPopupMenuMinimizeWindow", TRUE );
     ok( ret == 1, "TrackPopupMenu failed with error %li\n", GetLastError() );
     KillTimer( hwnd, TIMER_ID );
+
+    {
+        HWND foreground;
+        WCHAR class_name[32], window_text[32];
+        foreground = GetForegroundWindow();
+        GetClassNameW(foreground, class_name, ARRAY_SIZE(class_name));
+        GetWindowTextW(foreground, window_text, ARRAY_SIZE(window_text));
+        trace("foreground window: %p %s %s\n", foreground, debugstr_w(class_name), debugstr_w(window_text));
+    }
+
     ShowWindow( hwnd, SW_RESTORE );
 
     SetWindowLongPtrA( hwnd, GWLP_WNDPROC, (LONG_PTR)cancel_popup_proc);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/5408

[PATCH 1/1] debugging

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=144418

Your paranoid android.


=== w7u_2qxl (32 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w7u_adm (32 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w7u_el (32 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w8 (32 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w8adm (32 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w864 (32 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w1064v1507 (32 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w1064v1809 (32 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w1064_tsign (32 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w10pro64 (32 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w10pro64_en_AE_u8 (32 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w11pro64 (32 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w7pro64 (64 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w864 (64 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w1064v1507 (64 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w1064v1809 (64 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w1064_2qxl (64 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w1064_adm (64 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w1064_tsign (64 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w10pro64 (64 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w10pro64_ar (64 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w10pro64_ja (64 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w10pro64_zh_CN (64 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

=== w11pro64_amd (64 bit report) ===

user32:
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 38: the msg 0x0215 should NOT have been sent by DefWindowProc
msg.c:19863: Test failed: TrackPopupMenuMinimizeWindow: 42: the msg 0x001c was expected, but got winevent_hook 0x8001 instead

[PATCH 0/1] MR5408: Draft: debugging - closed

[Esme Povirk (＠madewokherd)]

This merge request was closed by Esme Povirk.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5408

[Esme Povirk (＠madewokherd)]

I just realized, this isn't going to work because the testbot will only run the changed test.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5408#note_66163