[PATCH 0/1] MR7258: winebuild: Make binaries without spec file reproduceable
From: Fabian Maurer <dark.shadow4(a)web.de> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41342 --- tools/winebuild/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/winebuild/main.c b/tools/winebuild/main.c index 63d65e7bcd0..354c9194959 100644 --- a/tools/winebuild/main.c +++ b/tools/winebuild/main.c @@ -111,7 +111,9 @@ static void init_dll_name( DLLSPEC *spec ) if (!spec->file_name && output_file_name) { char *p; - spec->file_name = xstrdup( output_file_name ); + char *copy = xstrdup( output_file_name ); + spec->file_name = xstrdup( basename(copy) ); + free( copy ); if ((p = strrchr( spec->file_name, '.' ))) *p = 0; } if (!spec->dll_name && spec->file_name) /* set default name from file name */ -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/7258
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=151236 Your paranoid android. === debian11b (64 bit WoW report) === kernel32: comm.c:1586: Test failed: Unexpected time 1001, expected around 500
Superseded by bd7813f51cc1a474e6c15aa14213fb8b1a94e7fe -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7258#note_93947
This merge request was closed by Fabian Maurer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7258
participants (3)
-
Fabian Maurer -
Fabian Maurer (@DarkShadow44) -
Marvin