[PATCH v3 0/1] MR7642: Draft: server: Fall back to epoll_wait if epoll_pwait2 isn't available at run-time.

[William Horvath (＠whrvt)]

This fixes a real problem and improves behavior at the same time.
 - Fixes: hanging when trying to run Wine built with epoll_pwait2 headers available
  but epoll_pwait2 is missing in the run-time kernel (i.e. build 5.11->run 5.10)

 - Improvement: bring the improved timeout resolution to Wine builds
  which didn't have epoll_pwait2 at compile time, if the run-time kernel supports it
  (i.e. build 5.10->run 6.14)

This last point is especially important in my opinion, as it applies to official Proton builds.
Proton is (currently) built in Debian 11 with kernel 5.10, but SteamOS is a moving target with
a much newer kernel version being used to run these Wine builds.

These builds use the lower resolution timeouts if epoll_pwait2 is only checked for at compile-time,
when it can cheaply and easily be done at run-time instead.

Fixes: 87ca5db40e2c1b37423bdc25101a5c5e39e67e6f

An alternative to !7640 that kills two birds with one stone.

--
  v3: server: Fall back to epoll_wait if epoll_pwait2 isn't available at run-time.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/7642

[PATCH v3 1/1] server: Fall back to epoll_wait if epoll_pwait2 isn't available at run-time.

[William Horvath]

From: William Horvath <william(a)horvath.blog>

This fixes a real problem and improves behavior at the same time.
 - Fixes: hanging when trying to run Wine built with epoll_pwait2 headers available
  but epoll_pwait2 is missing in the run-time kernel (i.e. build 5.11->run 5.10)

 - Improvement: bring the improved timeout resolution to Wine builds
  which didn't have epoll_pwait2 at compile time, if the run-time kernel supports it
  (i.e. build 5.10->run 6.14)

This last point is especially important in my opinion, as it applies to official Proton builds.
Proton is (currently) built in Debian 11 with kernel 5.10, but SteamOS is a moving target with
a much newer kernel version being used to run these Wine builds.

These builds use the lower resolution timeouts if epoll_pwait2 is only checked for at run-time,
when it can cheaply and easily be done at run-time instead.

Fixes: 87ca5db40e2c1b37423bdc25101a5c5e39e67e6f
---
 server/fd.c | 26 +++++++++++++++++++++-----
 1 file changed, 21 insertions(+), 5 deletions(-)

diff --git a/server/fd.c b/server/fd.c
index e1b969a0439..3d2639629ed 100644
--- a/server/fd.c
+++ b/server/fd.c
@@ -100,6 +100,7 @@
 #include "ddk/wdm.h"
 
 #if defined(HAVE_SYS_EPOLL_H) && defined(HAVE_EPOLL_CREATE)
+# include <dlfcn.h>
 # include <sys/epoll.h>
 # define USE_EPOLL
 #endif /* HAVE_SYS_EPOLL_H && HAVE_EPOLL_CREATE */
@@ -561,6 +562,20 @@ static inline void remove_epoll_user( struct fd *fd, int user )
     }
 }
 
+static int (*pepoll_pwait2)( int, struct epoll_event *, int, const struct timespec *, const sigset_t * );
+
+/* dispatch to the highest resolution epoll available */
+static inline int do_epoll_wait( struct epoll_event *events, int maxevents, const struct timespec *timeout_ts, int timeout_ms )
+{
+    if (pepoll_pwait2)
+    {
+        int ret = pepoll_pwait2( epoll_fd, events, maxevents, timeout_ts, NULL );
+        if (ret == -1 && errno == ENOSYS) pepoll_pwait2 = NULL; /* broken, fall back to epoll_wait */
+        else return ret;
+    }
+    return epoll_wait( epoll_fd, events, maxevents, timeout_ms );
+}
+
 static inline void main_loop_epoll(void)
 {
     int i, ret, timeout;
@@ -574,6 +589,11 @@ static inline void main_loop_epoll(void)
 
     if (epoll_fd == -1) return;
 
+#ifdef HAVE_EPOLL_PWAIT2
+    pepoll_pwait2 = &epoll_pwait2;
+#endif
+    if (!pepoll_pwait2) pepoll_pwait2 = dlsym( RTLD_DEFAULT, "epoll_pwait2" );
+
     while (active_users)
     {
         timeout = get_next_timeout( &ts );
@@ -581,11 +601,7 @@ static inline void main_loop_epoll(void)
         if (!active_users) break;  /* last user removed by a timeout */
         if (epoll_fd == -1) break;  /* an error occurred with epoll */
 
-#ifdef HAVE_EPOLL_PWAIT2
-        ret = epoll_pwait2( epoll_fd, events, ARRAY_SIZE( events ), timeout == -1 ? NULL : &ts, NULL );
-#else
-        ret = epoll_wait( epoll_fd, events, ARRAY_SIZE( events ), timeout );
-#endif
+        ret = do_epoll_wait( events, ARRAY_SIZE( events ), timeout == -1 ? NULL : &ts, timeout );
 
         set_current_time();
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/7642