[PATCH v2 0/1] MR408: ntdll: Fix x64 single step exception detection on macOS.

[Piotr Caban (＠piotr)]

On macOS si_code is always set to TRAP_BRKPT.

--
  v2: ntdll: Fix x64 single step exception detection on macOS.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/408

[PATCH v2 1/1] ntdll: Fix x64 single step exception detection on macOS.

[Piotr Caban]

From: Piotr Caban <piotr(a)codeweavers.com>

On macOS si_code is always set to TRAP_BRKPT.
---
 dlls/ntdll/unix/signal_x86_64.c | 16 +++-------------
 1 file changed, 3 insertions(+), 13 deletions(-)

diff --git a/dlls/ntdll/unix/signal_x86_64.c b/dlls/ntdll/unix/signal_x86_64.c
index 6c87e347eac..54353e50e3d 100644
--- a/dlls/ntdll/unix/signal_x86_64.c
+++ b/dlls/ntdll/unix/signal_x86_64.c
@@ -2693,22 +2693,12 @@ static void trap_handler( int signal, siginfo_t *siginfo, void *sigcontext )
     rec.ExceptionAddress = (void *)RIP_sig(ucontext);
     save_context( &context, sigcontext );
 
-    switch (siginfo->si_code)
+    switch (TRAP_sig(ucontext))
     {
-    case TRAP_TRACE:  /* Single-step exception */
-    case 4 /* TRAP_HWBKPT */: /* Hardware breakpoint exception */
+    case TRAP_x86_TRCTRAP:
         rec.ExceptionCode = EXCEPTION_SINGLE_STEP;
         break;
-    case TRAP_BRKPT:   /* Breakpoint exception */
-#ifdef SI_KERNEL
-    case SI_KERNEL:
-#endif
-        /* Check if this is actually icebp instruction */
-        if (((unsigned char *)RIP_sig(ucontext))[-1] == 0xF1)
-        {
-            rec.ExceptionCode = EXCEPTION_SINGLE_STEP;
-            break;
-        }
+    case TRAP_x86_BPTFLT:
         rec.ExceptionAddress = (char *)rec.ExceptionAddress - 1;  /* back up over the int3 instruction */
         /* fall through */
     default:
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/408

[Jinoh Kang (＠iamahuman)]

For reference: https://github.com/apple/darwin-xnu/blob/8f02f2a044b9bb1ad951987ef5bab20ec94...

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/408#note_3821