[PATCH v2 0/1] MR7859: gdi32/tests: Remove one test for NtGdiMakeFontDir.
The call to NtGdiMakeFontDir fails just below Windows 10-1607, therefore this test fails in Windows 10-1607 and above. Followup of 5a6a75a5ff. [Link to the pattern page.](https://test.winehq.org/data/patterns.html#gdi32:font) Edit: Outdated, was the first version of the patch: [A testbot run with this patch.](https://testbot.winehq.org/JobDetails.pl?Key=157999) -- v2: gdi32/tests: Remove one test for NtGdiMakeFontDir. https://gitlab.winehq.org/wine/wine/-/merge_requests/7859
From: Bernhard Übelacker <bernhardu(a)mailbox.org> The call to NtGdiMakeFontDir fails just below Windows 10-1607, therefore this test fails in Windows 10-1607 and above. Followup of 5a6a75a5ff. --- dlls/gdi32/tests/font.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/dlls/gdi32/tests/font.c b/dlls/gdi32/tests/font.c index f4ca6aeffb6..233a7d3a973 100644 --- a/dlls/gdi32/tests/font.c +++ b/dlls/gdi32/tests/font.c @@ -6117,8 +6117,6 @@ static void test_CreateScalableFontResource(void) ok( !ret, "got %lx\n", ret ); ret = pNtGdiMakeFontDir( 0, buffer, sizeof(*fontdir), nt_name.Buffer, 0 ); ok( !ret, "got %lx\n", ret ); - ret = pNtGdiMakeFontDir( 0, buffer, sizeof(*fontdir), nt_name.Buffer, nt_name.Length + 6 ); - ok( !ret, "got %lx\n", ret ); ret = pNtGdiMakeFontDir( 0, buffer, sizeof(*fontdir), nt_name.Buffer, nt_name.Length + 2 ); ok( ret, "NtGdiMakeFontDir failed\n" ); ok( fontdir->dfSize == 0x95, "wrong size %lx\n", fontdir->dfSize ); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/7859
v2: - Simply remove the test instead of trying to match windows behaviour. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7859#note_101784
On Thu Apr 24 08:36:24 2025 +0000, Bernhard Übelacker wrote:
changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/7859/diffs?diff_id=173320&start_sha=302fb46fa484fed011ee2fa4f21836df0ea4df4c#9a562c66de5ac819e19590d9210cef57a29e7f04_6121_6120) Thanks for having a look, removing is much less complicated. I submitted v2.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7859#note_101785
This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7859
participants (2)
-
Bernhard Übelacker -
Huw Davies (＠huw)