[PATCH v3 0/1] MR1331: mscoree: Add StrongNameTokenFromAssembly stub.

[Mohamad Al-Jaf (＠maljaf)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53296

--
  v3: mscoree: Add StrongNameTokenFromAssembly stub.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1331

[PATCH v3 1/1] mscoree: Add StrongNameTokenFromAssembly stub.

[Mohamad Al-Jaf]

From: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53296
---
v2: Forward mscorwks StrongNameTokenFromAssembly to mscoree.
v3: Fix last parameter.
---
 dlls/mscoree/mscoree.spec   | 2 +-
 dlls/mscoree/mscoree_main.c | 6 ++++++
 dlls/mscorwks/mscorwks.spec | 2 +-
 include/strongname.h        | 1 +
 4 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/dlls/mscoree/mscoree.spec b/dlls/mscoree/mscoree.spec
index 92dcfd89677..92e0f60b718 100644
--- a/dlls/mscoree/mscoree.spec
+++ b/dlls/mscoree/mscoree.spec
@@ -108,7 +108,7 @@
 @ stdcall StrongNameSignatureVerification(wstr long ptr)
 @ stdcall StrongNameSignatureVerificationEx(wstr long ptr)
 @ stub StrongNameSignatureVerificationFromImage
-@ stub StrongNameTokenFromAssembly
+@ stdcall StrongNameTokenFromAssembly(wstr ptr ptr)
 @ stub StrongNameTokenFromAssemblyEx
 @ stub StrongNameTokenFromPublicKey
 @ stub TranslateSecurityAttributes
diff --git a/dlls/mscoree/mscoree_main.c b/dlls/mscoree/mscoree_main.c
index e19d50595b4..a6134f0226b 100644
--- a/dlls/mscoree/mscoree_main.c
+++ b/dlls/mscoree/mscoree_main.c
@@ -625,6 +625,12 @@ BOOLEAN WINAPI StrongNameSignatureVerificationEx(LPCWSTR filename, BOOLEAN force
     return TRUE;
 }
 
+BOOLEAN WINAPI StrongNameTokenFromAssembly(LPCWSTR path, BYTE **token, ULONG *size)
+{
+    FIXME("(%s, %p, %p): stub\n", debugstr_w(path), token, size);
+    return FALSE;
+}
+
 HRESULT WINAPI CreateDebuggingInterfaceFromVersion(int nDebugVersion, LPCWSTR version, IUnknown **ppv)
 {
     static const WCHAR v2_0[] = {'v','2','.','0','.','5','0','7','2','7',0};
diff --git a/dlls/mscorwks/mscorwks.spec b/dlls/mscorwks/mscorwks.spec
index 617cde3173d..cf7cfdee47f 100644
--- a/dlls/mscorwks/mscorwks.spec
+++ b/dlls/mscorwks/mscorwks.spec
@@ -101,7 +101,7 @@
 @ stdcall StrongNameSignatureVerification(wstr long ptr) mscoree.StrongNameSignatureVerification
 @ stdcall StrongNameSignatureVerificationEx(wstr long ptr) mscoree.StrongNameSignatureVerificationEx
 @ stub StrongNameSignatureVerificationFromImage
-@ stub StrongNameTokenFromAssembly
+@ stdcall StrongNameTokenFromAssembly(wstr ptr ptr) mscoree.StrongNameTokenFromAssembly
 @ stub StrongNameTokenFromAssemblyEx
 @ stub StrongNameTokenFromPublicKey
 @ stub TranslateSecurityAttributes
diff --git a/include/strongname.h b/include/strongname.h
index f05861ad28d..1134d63d3b3 100644
--- a/include/strongname.h
+++ b/include/strongname.h
@@ -35,5 +35,6 @@
 
 BOOLEAN __stdcall StrongNameSignatureVerification(const WCHAR *path, DWORD flags, DWORD *ret_flags);
 BOOLEAN __stdcall StrongNameSignatureVerificationEx(const WCHAR *path, BOOLEAN force, BOOLEAN *verified);
+BOOLEAN __stdcall StrongNameTokenFromAssembly(const WCHAR *path, BYTE **token, ULONG *size);
 
 #endif
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1331

[Mohamad Al-Jaf (＠maljaf)]

On Fri Nov 11 19:00:36 2022 +0000, Esme Povirk wrote:
> This doesn't quite match the signature in MSDN,  which has a pointer for
> the last argument.
> https://learn.microsoft.com/en-us/dotnet/framework/unmanaged-api/strong-nami...
> Indeed, good catch.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1331#note_14101

[PATCH v3 0/1] MR1331: mscoree: Add StrongNameTokenFromAssembly stub. - approved

[Esme Povirk (＠madewokherd)]

This merge request was approved by Esme Povirk.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1331